fix: deps optimizer idle logic for workers (fix #8479) (#8511)

Author: patak-dev

packages/vite/src/node/optimizer/optimizer.ts

@@ -521,8 +521,12 @@ export async function initDepsOptimizer(
 
   function registerWorkersSource(id: string): void {
     workersSources.add(id)
+    // Avoid waiting for this id, as it may be blocked by the rollup
+    // bundling process of the worker that also depends on the optimizer
+    registeredIds = registeredIds.filter((registered) => registered.id !== id)
     if (waitingOn === id) {
       waitingOn = undefined
+      runOptimizerWhenIdle()
     }
   }
 
@@ -545,10 +549,12 @@ export async function initDepsOptimizer(
         waitingOn = next.id
         const afterLoad = () => {
           waitingOn = undefined
-          if (registeredIds.length > 0) {
-            runOptimizerWhenIdle()
-          } else if (!workersSources.has(next.id)) {
-            getDepsOptimizer(config)?.run()
+          if (!workersSources.has(next.id)) {
+            if (registeredIds.length > 0) {
+              runOptimizerWhenIdle()
+            } else {
+              getDepsOptimizer(config)?.run()
+            }
           }
         }
         next

playground/worker/dep-to-optimize/index.js

@@ -0,0 +1 @@
+export const msg = 'dep-to-optimize'

playground/worker/dep-to-optimize/package.json

@@ -0,0 +1,7 @@
+{
+  "name": "dep-to-optimize",
+  "private": true,
+  "version": "1.0.0",
+  "type": "module",
+  "main": "index.js"
+}

playground/worker/my-worker.ts

@@ -1,9 +1,10 @@
 import { mode, msg } from './modules/workerImport'
 import { bundleWithPlugin } from './modules/test-plugin'
+import { msg as msgFromDep } from 'dep-to-optimize'
 
 self.onmessage = (e) => {
   if (e.data === 'ping') {
-    self.postMessage({ msg, mode, bundleWithPlugin })
+    self.postMessage({ msg, mode, bundleWithPlugin, msgFromDep })
   }
 }
 

playground/worker/package.json

@@ -23,6 +23,9 @@
     "preview:relative-base": "cross-env WORKER_MODE=inline vite --config ./vite.config-relative-base.js preview",
     "debug": "node --inspect-brk ../../packages/vite/bin/vite"
   },
+  "dependencies": {
+    "dep-to-optimize": "file:./dep-to-optimize"
+  },
   "devDependencies": {
     "@vitejs/plugin-vue-jsx": "workspace:*"
   }