From 1e9615d8614458947a81e0d4753fe61f3a277cb3 Mon Sep 17 00:00:00 2001 From: patak Date: Thu, 17 Mar 2022 13:27:31 +0100 Subject: [PATCH] fix: overwrite deps info browserHash only on commit (#7359) --- packages/vite/src/node/optimizer/index.ts | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/packages/vite/src/node/optimizer/index.ts b/packages/vite/src/node/optimizer/index.ts index becc1dd5fad066..0c66edc4836850 100644 --- a/packages/vite/src/node/optimizer/index.ts +++ b/packages/vite/src/node/optimizer/index.ts @@ -519,12 +519,6 @@ export async function createOptimizeDepsRun( } if (alteredFiles) { - // Overrite individual hashes with the new global browserHash, a full page reload is required - // New deps that ended up with a different hash replaced while doing analysis import are going to - // return a not found so the browser doesn't cache them. And will properly get loaded after the reload - for (const id in deps) { - metadata.optimized[id].browserHash = newBrowserHash - } metadata.browserHash = newBrowserHash } @@ -533,6 +527,14 @@ export async function createOptimizeDepsRun( return { alteredFiles, commit() { + if (alteredFiles) { + // Overwrite individual hashes with the new global browserHash, a full page reload is required + // New deps that ended up with a different hash replaced while doing analysis import are going to + // return a not found so the browser doesn't cache them. And will properly get loaded after the reload + for (const id in deps) { + metadata.optimized[id].browserHash = newBrowserHash + } + } // Write metadata file, delete `deps` folder and rename the new `processing` folder to `deps` in sync commitProcessingDepsCacheSync() processing.resolve()