From 23f8e08fd56892700c42644ff00ce2830545b0bb Mon Sep 17 00:00:00 2001 From: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Sun, 22 May 2022 22:30:28 -0700 Subject: [PATCH] fix!: do not fixStacktrace by default (#7995) --- packages/vite/src/node/ssr/__tests__/ssrModuleLoader.spec.ts | 2 +- packages/vite/src/node/ssr/ssrModuleLoader.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/vite/src/node/ssr/__tests__/ssrModuleLoader.spec.ts b/packages/vite/src/node/ssr/__tests__/ssrModuleLoader.spec.ts index f69eedc409a007..aecf64b3586faf 100644 --- a/packages/vite/src/node/ssr/__tests__/ssrModuleLoader.spec.ts +++ b/packages/vite/src/node/ssr/__tests__/ssrModuleLoader.spec.ts @@ -13,7 +13,7 @@ test('always throw error when evaluating an wrong SSR module', async () => { const expectedErrors = [] for (const _ of [0, 1]) { try { - await viteServer.ssrLoadModule(badjs) + await viteServer.ssrLoadModule(badjs, { fixStacktrace: true }) } catch (e) { expectedErrors.push(e) } diff --git a/packages/vite/src/node/ssr/ssrModuleLoader.ts b/packages/vite/src/node/ssr/ssrModuleLoader.ts index c552d5431881eb..7f9731c417c566 100644 --- a/packages/vite/src/node/ssr/ssrModuleLoader.ts +++ b/packages/vite/src/node/ssr/ssrModuleLoader.ts @@ -206,7 +206,7 @@ async function instantiateModule( ) } catch (e) { mod.ssrError = e - if (e.stack && fixStacktrace !== false) { + if (e.stack && fixStacktrace) { const stacktrace = ssrRewriteStacktrace(e.stack, moduleGraph) rebindErrorStacktrace(e, stacktrace) server.config.logger.error(