From 2842fd63c150ac30560f95cc07d107c7b951f67a Mon Sep 17 00:00:00 2001 From: Romuald Brillout Date: Tue, 8 Nov 2022 09:54:59 +0100 Subject: [PATCH] chore: remove confusing comment --- packages/vite/src/node/plugins/resolve.ts | 3 --- packages/vite/src/node/utils.ts | 10 +--------- 2 files changed, 1 insertion(+), 12 deletions(-) diff --git a/packages/vite/src/node/plugins/resolve.ts b/packages/vite/src/node/plugins/resolve.ts index fcbd7644b6d857..cbe3ff26f3c5a7 100644 --- a/packages/vite/src/node/plugins/resolve.ts +++ b/packages/vite/src/node/plugins/resolve.ts @@ -531,9 +531,6 @@ function tryResolveFile( tryPrefix?: string, skipPackageJson?: boolean ): string | undefined { - // #2051 if we don't have read permission on a directory, existsSync() still - // works and will result in massively slow subsequent checks (which are - // unnecessary in the first place) if (isFileReadable(file)) { if (!fs.statSync(file).isDirectory()) { return getRealPath(file, options.preserveSymlinks) + postfix diff --git a/packages/vite/src/node/utils.ts b/packages/vite/src/node/utils.ts index 20e200648a081e..6e395d98b61140 100644 --- a/packages/vite/src/node/utils.ts +++ b/packages/vite/src/node/utils.ts @@ -535,18 +535,10 @@ export function writeFile( fs.writeFileSync(filename, content) } -/** - * Use fs.statSync(filename) instead of fs.existsSync(filename) - * #2051 if we don't have read permission on a directory, existsSync() still - * works and will result in massively slow subsequent checks (which are - * unnecessary in the first place) - */ export function isFileReadable(filename: string): boolean { try { - const stat = fs.statSync(filename, { throwIfNoEntry: false }) - // Test user permission. Throws error if no permission. fs.accessSync(filename, fs.constants.R_OK) - return !!stat + return true } catch { return false }