fix: virtual html sourcemap warning (#7440)

vitejs · Mar 24, 2022 · 476786b · 476786b
1 parent 47668b5
commit 476786b
Show file tree

Hide file tree

Showing 5 changed files with 32 additions and 2 deletions.
diff --git a/packages/playground/css-sourcemap/__tests__/serve.spec.ts b/packages/playground/css-sourcemap/__tests__/serve.spec.ts
@@ -83,6 +83,8 @@ if (!isBuild) {
 
         import './imported.styl'
       </script>
+
+      <iframe src=\\"virtual.html\\"></iframe>
       ",
         ],
         "version": 3,

diff --git a/packages/playground/css-sourcemap/index.html b/packages/playground/css-sourcemap/index.html
@@ -41,3 +41,5 @@ <h1>CSS Sourcemap</h1>
 
   import './imported.styl'
 </script>
+
+<iframe src="virtual.html"></iframe>
diff --git a/packages/playground/css-sourcemap/vite.config.js b/packages/playground/css-sourcemap/vite.config.js
@@ -36,5 +36,25 @@ module.exports = {
   },
   build: {
     sourcemap: true
-  }
+  },
+  plugins: [
+    {
+      name: 'virtual-html',
+      configureServer(server) {
+        server.middlewares.use(async (req, res, next) => {
+          if (req.url === '/virtual.html') {
+            const t = await server.transformIndexHtml(
+              '/virtual.html',
+              '<style> .foo { color: red; } </style> <p class="foo">virtual html</p>'
+            )
+            res.setHeader('Content-Type', 'text/html')
+            res.statusCode = 200
+            res.end(t)
+            return
+          }
+          next()
+        })
+      }
+    }
+  ]
 }
diff --git a/packages/vite/src/node/plugins/html.ts b/packages/vite/src/node/plugins/html.ts
@@ -705,6 +705,8 @@ export function resolveHtmlTransforms(
   return [preHooks, postHooks]
 }
 
+export const maybeVirtualHtmlSet = new Set<string>()
+
 export async function applyHtmlTransforms(
   html: string,
   hooks: IndexHtmlTransformHook[],
@@ -715,6 +717,8 @@ export async function applyHtmlTransforms(
   const bodyTags: HtmlTagDescriptor[] = []
   const bodyPrependTags: HtmlTagDescriptor[] = []
 
+  maybeVirtualHtmlSet.add(ctx.filename)
+
   for (const hook of hooks) {
     const res = await hook(html, ctx)
     if (!res) {

diff --git a/packages/vite/src/node/server/sourcemap.ts b/packages/vite/src/node/server/sourcemap.ts
@@ -1,8 +1,9 @@
 import path from 'path'
 import { promises as fs } from 'fs'
 import type { Logger } from '../logger'
-import { createDebugger } from '../utils'
+import { createDebugger, normalizePath } from '../utils'
 import type { SourceMap } from 'rollup'
+import { maybeVirtualHtmlSet } from '../plugins/html'
 
 const isDebug = !!process.env.DEBUG
 const debug = createDebugger('vite:sourcemap', {
@@ -42,6 +43,7 @@ export async function injectSourcesContent(
           sourcePath = path.resolve(sourceRoot, sourcePath)
         }
         return fs.readFile(sourcePath, 'utf-8').catch(() => {
+          if (maybeVirtualHtmlSet.has(normalizePath(sourcePath))) return null
           missingSources.push(sourcePath)
           return null
         })