fix: throws error when plugin tries to resolve ID to external URL (#1…

…1731) Co-authored-by: bluwy <bjornlu.dev@gmail.com>
vitejs · Mar 30, 2023 · 49674b5 · 49674b5
1 parent 82137d6
commit 49674b5
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/packages/vite/src/node/plugins/importAnalysis.ts b/packages/vite/src/node/plugins/importAnalysis.ts
@@ -601,7 +601,10 @@ export function importAnalysisPlugin(config: ResolvedConfig): Plugin {
           // record for HMR import chain analysis
           // make sure to unwrap and normalize away base
           const hmrUrl = unwrapId(stripBase(url, base))
-          importedUrls.add(hmrUrl)
+          const isLocalImport = !isExternalUrl(hmrUrl) && !isDataUrl(hmrUrl)
+          if (isLocalImport) {
+            importedUrls.add(hmrUrl)
+          }
 
           if (enablePartialAccept && importedBindings) {
             extractImportedBindings(
@@ -612,7 +615,7 @@ export function importAnalysisPlugin(config: ResolvedConfig): Plugin {
             )
           }
 
-          if (!isDynamicImport) {
+          if (!isDynamicImport && isLocalImport) {
             // for pre-transforming
             staticImportedUrls.add({ url: hmrUrl, id: resolvedId })
           }