Skip to content

Commit 4caf4b6

Browse files
authoredNov 9, 2022
feat!: set esbuild default charset to utf8 (#10753)
1 parent d5fe92c commit 4caf4b6

File tree

3 files changed

+11
-0
lines changed

3 files changed

+11
-0
lines changed
 

‎packages/vite/src/node/__tests__/plugins/esbuild.spec.ts

+7
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ describe('resolveEsbuildTranspileOptions', () => {
1717
'es'
1818
)
1919
expect(options).toEqual({
20+
charset: 'utf8',
2021
target: 'es2020',
2122
format: 'esm',
2223
keepNames: true,
@@ -59,6 +60,7 @@ describe('resolveEsbuildTranspileOptions', () => {
5960
'es'
6061
)
6162
expect(options).toEqual({
63+
charset: 'utf8',
6264
target: undefined,
6365
format: 'esm',
6466
keepNames: true,
@@ -88,6 +90,7 @@ describe('resolveEsbuildTranspileOptions', () => {
8890
'es'
8991
)
9092
expect(options).toEqual({
93+
charset: 'utf8',
9194
target: 'es2020',
9295
format: 'esm',
9396
keepNames: true,
@@ -119,6 +122,7 @@ describe('resolveEsbuildTranspileOptions', () => {
119122
'es'
120123
)
121124
expect(options).toEqual({
125+
charset: 'utf8',
122126
target: undefined,
123127
format: 'esm',
124128
keepNames: true,
@@ -150,6 +154,7 @@ describe('resolveEsbuildTranspileOptions', () => {
150154
'cjs'
151155
)
152156
expect(options).toEqual({
157+
charset: 'utf8',
153158
target: undefined,
154159
format: 'cjs',
155160
keepNames: true,
@@ -180,6 +185,7 @@ describe('resolveEsbuildTranspileOptions', () => {
180185
'es'
181186
)
182187
expect(options).toEqual({
188+
charset: 'utf8',
183189
target: undefined,
184190
format: 'esm',
185191
keepNames: true,
@@ -214,6 +220,7 @@ describe('resolveEsbuildTranspileOptions', () => {
214220
'cjs'
215221
)
216222
expect(options).toEqual({
223+
charset: 'utf8',
217224
target: undefined,
218225
format: 'cjs',
219226
keepNames: true,

‎packages/vite/src/node/optimizer/index.ts

+1
Original file line numberDiff line numberDiff line change
@@ -612,6 +612,7 @@ export async function runOptimizeDeps(
612612
ignoreAnnotations: !isBuild,
613613
metafile: true,
614614
plugins,
615+
charset: 'utf8',
615616
...esbuildOptions,
616617
supported: {
617618
'dynamic-import': true,

‎packages/vite/src/node/plugins/esbuild.ts

+3
Original file line numberDiff line numberDiff line change
@@ -180,6 +180,7 @@ export function esbuildPlugin(options: ESBuildOptions = {}): Plugin {
180180
// and for build as the final optimization is in `buildEsbuildPlugin`
181181
const transformOptions: TransformOptions = {
182182
target: 'esnext',
183+
charset: 'utf8',
183184
...options,
184185
minify: false,
185186
minifyIdentifiers: false,
@@ -306,7 +307,9 @@ export function resolveEsbuildTranspileOptions(
306307
// https://github.com/vuejs/core/issues/2860#issuecomment-926882793
307308
const isEsLibBuild = config.build.lib && format === 'es'
308309
const esbuildOptions = config.esbuild || {}
310+
309311
const options: TransformOptions = {
312+
charset: 'utf8',
310313
...esbuildOptions,
311314
target: target || undefined,
312315
format: rollupToEsbuildFormatMap[format],

0 commit comments

Comments
 (0)
Please sign in to comment.