fix: ssr.external/noExternal should apply to packageName (#9146)

vitejs · Jul 15, 2022 · 5844d8e · 5844d8e
1 parent 5ea70b3
commit 5844d8e
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/packages/vite/src/node/ssr/ssrExternal.ts b/packages/vite/src/node/ssr/ssrExternal.ts
@@ -120,13 +120,17 @@ export function createIsConfiguredAsSsrExternal(
   return (id: string) => {
     const { ssr } = config
     if (ssr) {
-      if (ssr.external?.includes(id)) {
+      const pkgName = getNpmPackageName(id)
+      if (!pkgName) {
+        return undefined
+      }
+      if (ssr.external?.includes(pkgName)) {
         return true
       }
       if (typeof noExternal === 'boolean') {
         return !noExternal
       }
-      if (noExternalFilter && !noExternalFilter(id)) {
+      if (noExternalFilter && !noExternalFilter(pkgName)) {
         return false
       }
     }