fix: warn on build when bundling code that uses nodejs built in module (#12616)

chaxus · bluwy · web-flow · commit 72050f913ff4 · 2023-04-07T17:04:26.000Z
Co-authored-by: bluwy &lt;bjornlu.dev@gmail.com&gt;
diff --git a/packages/vite/src/node/plugins/resolve.ts b/packages/vite/src/node/plugins/resolve.ts
@@ -382,6 +382,11 @@ export function resolvePlugin(resolveOptions: InternalResolveOptions): Plugin {
                 `externalized node built-in "${id}" to empty module. ` +
                   `(imported by: ${colors.white(colors.dim(importer))})`,
               )
+            } else if (isProduction) {
+              this.warn(
+                `Module "${id}" has been externalized for browser compatibility, imported by "${importer}". ` +
+                  `See http://vitejs.dev/guide/troubleshooting.html#module-externalized-for-browser-compatibility for more details.`,
+              )
             }
             return isProduction
               ? browserExternalId

Original file line number	Diff line number	Diff line change
`@@ -382,6 +382,11 @@ export function resolvePlugin(resolveOptions: InternalResolveOptions): Plugin {`
`382`	`382`	`externalized node built-in "${id}" to empty module. ` +
`383`	`383`	`(imported by: ${colors.white(colors.dim(importer))})`,
`384`	`384`	`)`
	`385`	`+ } else if (isProduction) {`
	`386`	`+ this.warn(`
	`387`	+ `Module "${id}" has been externalized for browser compatibility, imported by "${importer}". ` +
	`388`	+ `See http://vitejs.dev/guide/troubleshooting.html#module-externalized-for-browser-compatibility for more details.`,
	`389`	`+ )`
`385`	`390`	`}`
`386`	`391`	`return isProduction`
`387`	`392`	`? browserExternalId`