From 7d52fe8641121f071c11a8f66257598294eb3d3b Mon Sep 17 00:00:00 2001 From: Oliver Tsang <517578480@qq.com> Date: Wed, 9 Feb 2022 02:20:43 +0800 Subject: [PATCH] fix: allow reusing variable names between module scripts in entry html (#6851) --- .../__tests__/optimize-deps.spec.ts | 4 + packages/playground/optimize-deps/index.html | 19 ++++- packages/vite/src/node/optimizer/scan.ts | 73 +++++++++---------- 3 files changed, 53 insertions(+), 43 deletions(-) diff --git a/packages/playground/optimize-deps/__tests__/optimize-deps.spec.ts b/packages/playground/optimize-deps/__tests__/optimize-deps.spec.ts index 706998c288fa50..f8f937c628ba68 100644 --- a/packages/playground/optimize-deps/__tests__/optimize-deps.spec.ts +++ b/packages/playground/optimize-deps/__tests__/optimize-deps.spec.ts @@ -87,3 +87,7 @@ test('import from hidden dir', async () => { test('import optimize-excluded package that imports optimized-included package', async () => { expect(await page.textContent('.nested-include')).toBe('nested-include') }) + +test('variable names are reused in different scripts', async () => { + expect(await page.textContent('.reused-variable-names')).toBe('reused') +}) diff --git a/packages/playground/optimize-deps/index.html b/packages/playground/optimize-deps/index.html index dfb274656f1baf..62541e0525a9b4 100644 --- a/packages/playground/optimize-deps/index.html +++ b/packages/playground/optimize-deps/index.html @@ -53,6 +53,15 @@