From 891e7fc4fa3e047be43df5c1a4703cda4a4a1f54 Mon Sep 17 00:00:00 2001
From: TrickyPi <33021497+TrickyPi@users.noreply.github.com>
Date: Sun, 1 May 2022 03:11:37 +0800
Subject: [PATCH] fix(ssr): failed ssrLoadModule call throws same error (#7177)

Co-authored-by: Rich Harris <hello@rich-harris.dev>
---
 packages/vite/src/node/server/moduleGraph.ts  |  1 +
 .../__tests__/fixtures/ssrModuleLoader-bad.js |  2 ++
 .../ssr/__tests__/ssrModuleLoader.spec.ts     | 29 +++++++++++++++++++
 packages/vite/src/node/ssr/ssrModuleLoader.ts |  5 ++++
 4 files changed, 37 insertions(+)
 create mode 100644 packages/vite/src/node/ssr/__tests__/fixtures/ssrModuleLoader-bad.js
 create mode 100644 packages/vite/src/node/ssr/__tests__/ssrModuleLoader.spec.ts

diff --git a/packages/vite/src/node/server/moduleGraph.ts b/packages/vite/src/node/server/moduleGraph.ts
index 9c9f0d84bb738f..1d7ae407f110c5 100644
--- a/packages/vite/src/node/server/moduleGraph.ts
+++ b/packages/vite/src/node/server/moduleGraph.ts
@@ -33,6 +33,7 @@ export class ModuleNode {
   transformResult: TransformResult | null = null
   ssrTransformResult: TransformResult | null = null
   ssrModule: Record<string, any> | null = null
+  ssrError: Error | null = null
   lastHMRTimestamp = 0
   lastInvalidationTimestamp = 0
 
diff --git a/packages/vite/src/node/ssr/__tests__/fixtures/ssrModuleLoader-bad.js b/packages/vite/src/node/ssr/__tests__/fixtures/ssrModuleLoader-bad.js
new file mode 100644
index 00000000000000..a51a0519d34003
--- /dev/null
+++ b/packages/vite/src/node/ssr/__tests__/fixtures/ssrModuleLoader-bad.js
@@ -0,0 +1,2 @@
+export const bad = 1
+throw new Error('it is an expected error')
diff --git a/packages/vite/src/node/ssr/__tests__/ssrModuleLoader.spec.ts b/packages/vite/src/node/ssr/__tests__/ssrModuleLoader.spec.ts
new file mode 100644
index 00000000000000..6a45a2b70509d0
--- /dev/null
+++ b/packages/vite/src/node/ssr/__tests__/ssrModuleLoader.spec.ts
@@ -0,0 +1,29 @@
+import { resolve } from 'path'
+import { createServer } from '../../index'
+
+const badjs = resolve(__dirname, './fixtures/ssrModuleLoader-bad.js')
+const THROW_MESSAGE = 'it is an expected error'
+
+test('always throw error when evaluating an wrong SSR module', async () => {
+  const viteServer = await createServer()
+  const spy = jest.spyOn(console, 'error').mockImplementation(() => {})
+  const expectedErrors = []
+  for (const i of [0, 1]) {
+    try {
+      await viteServer.ssrLoadModule(badjs)
+    } catch (e) {
+      expectedErrors.push(e)
+    }
+  }
+  await viteServer.close()
+  expect(expectedErrors).toHaveLength(2)
+  expect(expectedErrors[0]).toBe(expectedErrors[1])
+  expectedErrors.forEach((error) => {
+    expect(error?.message).toContain(THROW_MESSAGE)
+  })
+  expect(spy).toBeCalledTimes(1)
+  const [firstParameter] = spy.mock.calls[0]
+  expect(firstParameter).toContain('Error when evaluating SSR module')
+  expect(firstParameter).toContain(THROW_MESSAGE)
+  spy.mockClear()
+})
diff --git a/packages/vite/src/node/ssr/ssrModuleLoader.ts b/packages/vite/src/node/ssr/ssrModuleLoader.ts
index de31c6a20266c5..8b3a423f58aeab 100644
--- a/packages/vite/src/node/ssr/ssrModuleLoader.ts
+++ b/packages/vite/src/node/ssr/ssrModuleLoader.ts
@@ -77,6 +77,10 @@ async function instantiateModule(
   const { moduleGraph } = server
   const mod = await moduleGraph.ensureEntryFromUrl(url, true)
 
+  if (mod.ssrError) {
+    throw mod.ssrError
+  }
+
   if (mod.ssrModule) {
     return mod.ssrModule
   }
@@ -202,6 +206,7 @@ async function instantiateModule(
       ssrExportAll
     )
   } catch (e) {
+    mod.ssrError = e
     if (e.stack && fixStacktrace !== false) {
       const stacktrace = ssrRewriteStacktrace(e.stack, moduleGraph)
       rebindErrorStacktrace(e, stacktrace)