From a32c4bad5fd937874dc721fbcfb96ba1d4de4122 Mon Sep 17 00:00:00 2001
From: Bjorn Lu <bjornlu.dev@gmail.com>
Date: Fri, 17 Jun 2022 14:02:56 +0800
Subject: [PATCH] fix(optimizer): use simple browser external shim in prod
 (#8630)

---
 .../src/node/optimizer/esbuildDepPlugin.ts    | 42 +++++++++++--------
 1 file changed, 24 insertions(+), 18 deletions(-)

diff --git a/packages/vite/src/node/optimizer/esbuildDepPlugin.ts b/packages/vite/src/node/optimizer/esbuildDepPlugin.ts
index 6ab689f856df55..aacabbdf9b1a3c 100644
--- a/packages/vite/src/node/optimizer/esbuildDepPlugin.ts
+++ b/packages/vite/src/node/optimizer/esbuildDepPlugin.ts
@@ -224,24 +224,29 @@ export function esbuildDepPlugin(
       build.onLoad(
         { filter: /.*/, namespace: 'browser-external' },
         ({ path }) => {
-          return {
-            // Return in CJS to intercept named imports. Use `Object.create` to
-            // create the Proxy in the prototype to workaround esbuild issue. Why?
-            //
-            // In short, esbuild cjs->esm flow:
-            // 1. Create empty object using `Object.create(Object.getPrototypeOf(module.exports))`.
-            // 2. Assign props of `module.exports` to the object.
-            // 3. Return object for ESM use.
-            //
-            // If we do `module.exports = new Proxy({}, {})`, step 1 returns empty object,
-            // step 2 does nothing as there's no props for `module.exports`. The final object
-            // is just an empty object.
-            //
-            // Creating the Proxy in the prototype satisfies step 1 immediately, which means
-            // the returned object is a Proxy that we can intercept.
-            //
-            // Note: Skip keys that are accessed by esbuild and browser devtools.
-            contents: `\
+          if (config.isProduction) {
+            return {
+              contents: 'module.exports = {}'
+            }
+          } else {
+            return {
+              // Return in CJS to intercept named imports. Use `Object.create` to
+              // create the Proxy in the prototype to workaround esbuild issue. Why?
+              //
+              // In short, esbuild cjs->esm flow:
+              // 1. Create empty object using `Object.create(Object.getPrototypeOf(module.exports))`.
+              // 2. Assign props of `module.exports` to the object.
+              // 3. Return object for ESM use.
+              //
+              // If we do `module.exports = new Proxy({}, {})`, step 1 returns empty object,
+              // step 2 does nothing as there's no props for `module.exports`. The final object
+              // is just an empty object.
+              //
+              // Creating the Proxy in the prototype satisfies step 1 immediately, which means
+              // the returned object is a Proxy that we can intercept.
+              //
+              // Note: Skip keys that are accessed by esbuild and browser devtools.
+              contents: `\
 module.exports = Object.create(new Proxy({}, {
   get(_, key) {
     if (
@@ -254,6 +259,7 @@ module.exports = Object.create(new Proxy({}, {
     }
   }
 }))`
+            }
           }
         }
       )