From b40fd9187f897b0695f6d4a0adccf21d57c2f1bd Mon Sep 17 00:00:00 2001 From: Tony Trinh Date: Thu, 1 Sep 2022 00:48:25 -0500 Subject: [PATCH] perf(define): don't compare id if no replacements needed --- packages/vite/src/node/plugins/define.ts | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/packages/vite/src/node/plugins/define.ts b/packages/vite/src/node/plugins/define.ts index 7fb153a0653c2d..eee640e5890ab5 100644 --- a/packages/vite/src/node/plugins/define.ts +++ b/packages/vite/src/node/plugins/define.ts @@ -110,6 +110,11 @@ export function definePlugin(config: ResolvedConfig): Plugin { return } + const [replacements, pattern] = ssr ? ssrPattern : defaultPattern + if (!pattern) { + return null + } + if ( // exclude html, css and static assets for performance isHTMLRequest(id) || @@ -120,12 +125,6 @@ export function definePlugin(config: ResolvedConfig): Plugin { return } - const [replacements, pattern] = ssr ? ssrPattern : defaultPattern - - if (!pattern) { - return null - } - const s = replaceInCode(code, pattern, replacements) return s ? transformStableResult(s, id, config) : null }