From c46b56d3ef54d2ae01cc6d51252cb12fc3d3c898 Mon Sep 17 00:00:00 2001 From: OliverTsang <45007307+OliverTsang@users.noreply.github.com> Date: Sat, 5 Mar 2022 06:33:42 +0800 Subject: [PATCH] fix: reusing variable names in html module scripts (fix #6851) (#6818) --- .../__tests__/optimize-deps.spec.ts | 4 + packages/playground/optimize-deps/index.html | 19 +++- packages/vite/src/node/optimizer/scan.ts | 93 ++++++++++--------- 3 files changed, 69 insertions(+), 47 deletions(-) diff --git a/packages/playground/optimize-deps/__tests__/optimize-deps.spec.ts b/packages/playground/optimize-deps/__tests__/optimize-deps.spec.ts index 992627c6374df0..3c45287017fb44 100644 --- a/packages/playground/optimize-deps/__tests__/optimize-deps.spec.ts +++ b/packages/playground/optimize-deps/__tests__/optimize-deps.spec.ts @@ -95,3 +95,7 @@ test('import optimize-excluded package that imports optimized-included package', test('import aliased package with colon', async () => { expect(await page.textContent('.url')).toBe('vitejs.dev') }) + +test('variable names are reused in different scripts', async () => { + expect(await page.textContent('.reused-variable-names')).toBe('reused') +}) diff --git a/packages/playground/optimize-deps/index.html b/packages/playground/optimize-deps/index.html index e53e3375e79768..fc1b83a6b50c65 100644 --- a/packages/playground/optimize-deps/index.html +++ b/packages/playground/optimize-deps/index.html @@ -59,6 +59,15 @@