From cf59005a79dd7227f3ad63280761060ba224ce09 Mon Sep 17 00:00:00 2001 From: Bjorn Lu Date: Mon, 4 Apr 2022 12:42:43 +0800 Subject: [PATCH] fix: use correct proxy config in preview (#7604) --- packages/vite/src/node/preview.ts | 5 +++-- packages/vite/src/node/server/index.ts | 2 +- packages/vite/src/node/server/middlewares/proxy.ts | 5 ++--- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/vite/src/node/preview.ts b/packages/vite/src/node/preview.ts index 56dee04e2e2e07..c00f62a9cb8f0c 100644 --- a/packages/vite/src/node/preview.ts +++ b/packages/vite/src/node/preview.ts @@ -78,8 +78,9 @@ export async function preview( } // proxy - if (config.preview.proxy) { - app.use(proxyMiddleware(httpServer, config)) + const { proxy } = config.preview + if (proxy) { + app.use(proxyMiddleware(httpServer, proxy, config)) } app.use(compression()) diff --git a/packages/vite/src/node/server/index.ts b/packages/vite/src/node/server/index.ts index 996b7601e84786..de80ac1147ff0f 100644 --- a/packages/vite/src/node/server/index.ts +++ b/packages/vite/src/node/server/index.ts @@ -516,7 +516,7 @@ export async function createServer( // proxy const { proxy } = serverConfig if (proxy) { - middlewares.use(proxyMiddleware(httpServer, config)) + middlewares.use(proxyMiddleware(httpServer, proxy, config)) } // base diff --git a/packages/vite/src/node/server/middlewares/proxy.ts b/packages/vite/src/node/server/middlewares/proxy.ts index aa1100f13d5229..97de98a8331a7a 100644 --- a/packages/vite/src/node/server/middlewares/proxy.ts +++ b/packages/vite/src/node/server/middlewares/proxy.ts @@ -5,7 +5,7 @@ import { HMR_HEADER } from '../ws' import type { Connect } from 'types/connect' import type { HttpProxy } from 'types/http-proxy' import colors from 'picocolors' -import type { ResolvedConfig } from '../..' +import type { CommonServerOptions, ResolvedConfig } from '../..' const debug = createDebugger('vite:proxy') @@ -30,10 +30,9 @@ export interface ProxyOptions extends HttpProxy.ServerOptions { export function proxyMiddleware( httpServer: http.Server | null, + options: NonNullable, config: ResolvedConfig ): Connect.NextHandleFunction { - const options = config.server.proxy! - // lazy require only when proxy is used const proxies: Record = {}