fix(ssr): allow virtual paths on node modules (#9405)

packages/vite/src/node/ssr/ssrExternal.ts

@@ -129,20 +129,25 @@ export function createIsConfiguredAsSsrExternal(
     if (!bareImportRE.test(id) || id.includes('\0')) {
       return false
     }
-    return !!tryNodeResolve(
-      id,
-      undefined,
-      resolveOptions,
-      ssr?.target === 'webworker',
-      undefined,
-      true,
-      // try to externalize, will return undefined or an object without
-      // a external flag if it isn't externalizable
-      true,
-      // Allow linked packages to be externalized if they are explicitly
-      // configured as external
-      !!configuredAsExternal
-    )?.external
+    try {
+      return !!tryNodeResolve(
+        id,
+        undefined,
+        resolveOptions,
+        ssr?.target === 'webworker',
+        undefined,
+        true,
+        // try to externalize, will return undefined or an object without
+        // a external flag if it isn't externalizable
+        true,
+        // Allow linked packages to be externalized if they are explicitly
+        // configured as external
+        !!configuredAsExternal
+      )?.external
+    } catch (e) {
+      // may be an invalid import that's resolved by a plugin
+      return false
+    }
   }
 
   // Returns true if it is configured as external, false if it is filtered

playground/ssr-deps/__tests__/ssr-deps.spec.ts

@@ -103,3 +103,8 @@ test('msg from linked no external', async () => {
   await page.goto(url)
   expect(await page.textContent('.linked-no-external')).toMatch('Hello World!')
 })
+
+test('msg from linked no external', async () => {
+  await page.goto(url)
+  expect(await page.textContent('.dep-virtual')).toMatch('[success]')
+})

playground/ssr-deps/package.json

@@ -27,7 +27,8 @@
     "optimized-cjs-with-nested-external": "file:./optimized-with-nested-external",
     "external-using-external-entry": "file:./external-using-external-entry",
     "external-entry": "file:./external-entry",
-    "linked-no-external": "link:./linked-no-external"
+    "linked-no-external": "link:./linked-no-external",
+    "pkg-exports": "file:./pkg-exports"
   },
   "devDependencies": {
     "cross-env": "^7.0.3",

playground/ssr-deps/pkg-exports/index.js

@@ -0,0 +1 @@
+export default undefined

playground/ssr-deps/pkg-exports/package.json

@@ -0,0 +1,9 @@
+{
+  "name": "pkg-exports",
+  "private": true,
+  "version": "0.0.0",
+  "exports": {
+    ".": "./index.js"
+  },
+  "type": "module"
+}

playground/ssr-deps/server.js

@@ -45,7 +45,23 @@ export async function createServer(root = process.cwd(), hmrPort) {
       optimizeDeps: {
         disabled: 'build'
       }
-    }
+    },
+    plugins: [
+      {
+        name: 'dep-virtual',
+        enforce: 'pre',
+        resolveId(id) {
+          if (id === 'pkg-exports/virtual') {
+            return 'pkg-exports/virtual'
+          }
+        },
+        load(id) {
+          if (id === 'pkg-exports/virtual') {
+            return 'export default "[success]"'
+          }
+        }
+      }
+    ]
   })
   // use vite's connect instance as middleware
   app.use(vite.middlewares)

playground/ssr-deps/src/app.js

@@ -12,6 +12,7 @@ import requireAbsolute from 'require-absolute'
 import noExternalCjs from 'no-external-cjs'
 import importBuiltinCjs from 'import-builtin-cjs'
 import { hello as linkedNoExternal } from 'linked-no-external'
+import virtualMessage from 'pkg-exports/virtual'
 
 // This import will set a 'Hello World!" message in the nested-external non-entry dependency
 import 'non-optimized-with-nested-external'
@@ -79,5 +80,7 @@ export async function render(url, rootDir) {
   const linkedNoExternalMessage = linkedNoExternal()
   html += `\n<p class="linked-no-external">message from linked-no-external: ${linkedNoExternalMessage}</p>`
 
+  html += `\n<p class="dep-virtual">message from dep-virtual: ${virtualMessage}</p>`
+
   return html + '\n'
 }