From f24c2b03d7f4f23d5b22f4ca9d2713f08e385c53 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Arnaud=20Barr=C3=A9?= <arnaud.barre@carbometrix.com>
Date: Mon, 13 Mar 2023 06:34:54 +0100
Subject: [PATCH] feat: default esbuild jsxDev based on config.isProduction
 (#12386)

---
 packages/vite/src/node/config.ts          | 8 ++++++++
 packages/vite/src/node/plugins/esbuild.ts | 2 +-
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/packages/vite/src/node/config.ts b/packages/vite/src/node/config.ts
index 417e351e67c9cb..392e99a6c58ce7 100644
--- a/packages/vite/src/node/config.ts
+++ b/packages/vite/src/node/config.ts
@@ -348,6 +348,7 @@ export type ResolvedConfig = Readonly<
       alias: Alias[]
     }
     plugins: readonly Plugin[]
+    esbuild: ESBuildOptions | false
     server: ResolvedServerOptions
     build: ResolvedBuildOptions
     preview: ResolvedPreviewOptions
@@ -657,6 +658,13 @@ export async function resolveConfig(
     mainConfig: null,
     isProduction,
     plugins: userPlugins,
+    esbuild:
+      config.esbuild === false
+        ? false
+        : {
+            jsxDev: !isProduction,
+            ...config.esbuild,
+          },
     server,
     build: resolvedBuildOptions,
     preview: resolvePreviewOptions(config.preview, server),
diff --git a/packages/vite/src/node/plugins/esbuild.ts b/packages/vite/src/node/plugins/esbuild.ts
index 24323a6a0b7355..5db99c648bf4e0 100644
--- a/packages/vite/src/node/plugins/esbuild.ts
+++ b/packages/vite/src/node/plugins/esbuild.ts
@@ -209,7 +209,7 @@ export async function transformWithEsbuild(
   }
 }
 
-export function esbuildPlugin(options: ESBuildOptions = {}): Plugin {
+export function esbuildPlugin(options: ESBuildOptions): Plugin {
   const filter = createFilter(
     options.include || /\.(m?ts|[jt]sx)$/,
     options.exclude || /\.js$/,