Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(client): Add data-id attribute to style elements #10080

Merged
merged 3 commits into from Sep 23, 2022
Merged

feat(client): Add data-id attribute to style elements #10080

merged 3 commits into from Sep 23, 2022

Conversation

ArnaudBarre
Copy link
Member

@ArnaudBarre ArnaudBarre commented Sep 12, 2022 •
edited

Description

The goal is to be able to find quickly the output of some CSS files and to better see in which order files are being bundled

Screenshot 2022-09-12 at 10 18 33

We could inject the project ROOT to display relative id

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev patak-dev added p2-to-be-discussed Enhancement under consideration (priority) feat: css labels Sep 17, 2022
@ArnaudBarre @bluwy
Update packages/vite/src/client/client.ts
d9cf44e 
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
@bluwy bluwy enabled auto-merge (squash) September 23, 2022 13:44
@bluwy bluwy merged commit ea09fde into vitejs:main Sep 23, 2022
@ArnaudBarre ArnaudBarre deleted the styles-data-id branch September 24, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
feat: css p2-to-be-discussed Enhancement under consideration (priority)
Projects
Team Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ArnaudBarre @bluwy @patak-dev