Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: env variables override #10113

Merged
merged 6 commits into from Oct 5, 2022
Merged

fix: env variables override #10113

merged 6 commits into from Oct 5, 2022

Conversation

Dunqing
Copy link
Contributor

@Dunqing Dunqing commented Sep 14, 2022 •
edited

Description

fix: #10008

Also, I think ignoreProcessEnv should be set to false, as this is very useful in CI builds.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p3-minor-bug An edge case that only affects very specific usage (priority) label Sep 19, 2022
sapphi-red
sapphi-red requested changes Sep 19, 2022
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

packages/vite/src/node/__tests__/env.spec.ts Outdated Show resolved Hide resolved
packages/vite/src/node/__tests__/env.spec.ts Outdated Show resolved Hide resolved
packages/vite/src/node/env.ts Outdated Show resolved Hide resolved
bluwy
bluwy reviewed Sep 23, 2022
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me with a nit.

Also, I think ignoreProcessEnv should be set to false, as this is very useful in CI builds.

I don't think we'd want to pollute process.env. for the Vite envs, but perhaps you're referring to #6626 ?

packages/vite/src/node/env.ts Show resolved Hide resolved
@Dunqing
Copy link
Contributor Author

Dunqing commented Sep 24, 2022

but perhaps you're referring to #6626 ?

Yes

sapphi-red
sapphi-red approved these changes Sep 25, 2022
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sapphi-red sapphi-red merged commit d619460 into vitejs:main Oct 5, 2022
@sapphi-red sapphi-red mentioned this pull request Oct 28, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ydcjeff ydcjeff ydcjeff approved these changes

@bluwy bluwy bluwy approved these changes

@sapphi-red sapphi-red sapphi-red approved these changes

Assignees
No one assigned
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

loadEnv overrides mode env file
4 participants
@Dunqing @ydcjeff @bluwy @sapphi-red