Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(worker): support comment in worker constructor option #10226

Merged
merged 2 commits into from Sep 24, 2022
Merged

fix(worker): support comment in worker constructor option #10226

merged 2 commits into from Sep 24, 2022

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Sep 24, 2022 •
edited

Description

A follow up of #10211 to support comment in worker constructor option. Encountered this when testing with the reproduction of #10206.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

bluwy
bluwy approved these changes Sep 24, 2022
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a much better implementation than mine. Thanks for bringing this up 💚

@bluwy bluwy merged commit 66c9058 into vitejs:main Sep 24, 2022
@ydcjeff ydcjeff deleted the worker-options-cmt branch September 24, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ydcjeff @bluwy