Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: inconsistent handling of non-ASCII base in resolveConfig and dev server #10247

Merged
merged 7 commits into from Nov 7, 2022
Merged

fix: inconsistent handling of non-ASCII base in resolveConfig and dev server #10247

merged 7 commits into from Nov 7, 2022

Conversation

PengBoUESTC
Copy link
Contributor

Description

format config.base by URL

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

@PengBoUESTC PengBoUESTC changed the title Feature/config base format config base format Sep 26, 2022
@PengBoUESTC
Copy link
Contributor Author

截屏2022-09-26 上午11 00 16

@PengBoUESTC PengBoUESTC changed the title config base format feature: config base format Sep 26, 2022
@PengBoUESTC PengBoUESTC changed the title feature: config base format feat: config base format Sep 26, 2022
sodatea
sodatea requested changes Oct 8, 2022
View reviewed changes
Copy link
Member

@sodatea sodatea left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lack of detailed explanation of what this PR does.
Maybe you can create an issue for this feature first?

@PengBoUESTC
Copy link
Contributor Author

Lack of detailed explanation of what this PR does. Maybe you can create an issue for this feature first?

That may be not necessary, actually, there may be little users set base url to Chinese or Japanese ... The main purpose of this PR is to let the parse of base url stay the same as others.

And here is the discussion config base with chinese will make some mistakes

@sodatea
Copy link
Member

sodatea commented Oct 9, 2022

Thanks. I get that they are inconsistent.
But what are the exact bugs?
Is this PR a bug fix, a new feature, or a refactoring?

@PengBoUESTC
Copy link
Contributor Author

refactoring

refactoring ^_^

@PengBoUESTC
Copy link
Contributor Author

Thanks. I get that they are inconsistent. But what are the exact bugs? Is this PR a bug fix, a new feature, or a refactoring?

what does this PR have done

PengBoUESTC
PengBoUESTC commented Oct 13, 2022
View reviewed changes
Copy link
Contributor Author

@PengBoUESTC PengBoUESTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code update need review

@PengBoUESTC
Copy link
Contributor Author

PengBoUESTC commented Oct 19, 2022 •
edited

#10534

@sodatea I provide a demo about this question

@PengBoUESTC PengBoUESTC mentioned this pull request Oct 19, 2022
Closed
7 tasks
PengBoUESTC
PengBoUESTC commented Nov 3, 2022
View reviewed changes
Copy link
Contributor Author

@PengBoUESTC PengBoUESTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#10534

@sodatea sodatea added the p3-minor-bug An edge case that only affects very specific usage (priority) label Nov 4, 2022
sodatea
sodatea approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@sodatea sodatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@PengBoUESTC
Copy link
Contributor Author

Looks good to me. Thanks!

Thanks a lot

@sodatea sodatea changed the title feat: config base format fix: inconsistent handling of non-ASCII base in resolveConfig and dev server Nov 7, 2022
@patak-dev patak-dev merged commit 16e4123 into vitejs:main Nov 7, 2022
@PengBoUESTC PengBoUESTC deleted the feature/config-base-format branch January 11, 2023 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@sodatea sodatea sodatea approved these changes

Assignees
No one assigned
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PengBoUESTC @sodatea @patak-dev