Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: isFromTsImporter flag in worker virtual model #10273

Merged
merged 3 commits into from Sep 28, 2022

Conversation

poyoho
Copy link
Member

@poyoho poyoho commented Sep 28, 2022

Description

fix: #9882

Additional context

if in worker virtual model will splitFileAndPostfix(importer) first and set options.isFromTsImporter.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@poyoho poyoho changed the title test: worker extends fix: isFromTsImporter flag in worker virtual model Sep 28, 2022
@patak-dev patak-dev added the p3-significant High priority enhancement (priority) label Sep 28, 2022
@patak-dev
Copy link
Member

@poyoho maybe we should apply this one also to the v3.1 branch too?

@poyoho
Copy link
Member Author

poyoho commented Sep 28, 2022

This should only affect the function of the worker. I think is ok 😁

@patak-dev patak-dev merged commit 78f74c9 into vitejs:main Sep 28, 2022
@poyoho poyoho deleted the fix/worker-deps branch September 28, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-significant High priority enhancement (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing a .js typescript resource from a typescript file fails in a worker
2 participants