Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add a warning if css urls not exist during build time (fix #9800) #10331

Merged
merged 2 commits into from Oct 24, 2022

Conversation

Megrax
Copy link
Contributor

@Megrax Megrax commented Oct 3, 2022

Description

Closes #9800

Print a warning message if we cannot resolve a css-url during build time.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Megrax
Copy link
Contributor Author

Megrax commented Oct 5, 2022

@sapphi-red I just added a warning here during build time, due to #9800 (comment). Not sure if this is enough in this situation. 😊

@sapphi-red sapphi-red added the p2-nice-to-have Not breaking anything but nice to have (priority) label Oct 20, 2022
Co-authored-by: 翠 / green <green@sapphi.red>
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Megrax
Copy link
Contributor Author

Megrax commented Oct 24, 2022

Hi @sapphi-red @patak-dev, is there any plan to merge this?

@patak-dev patak-dev merged commit 9f268da into vitejs:main Oct 24, 2022
@ScopeyNZ
Copy link

ScopeyNZ commented Nov 2, 2022

This warning doesn't consider rollup externals. My project relies on many assets that aren't available to our builder and now our logs are filled with this warning. Should I make a new issue to follow up on this?

@patak-dev
Copy link
Member

Yes, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

static assets in CSS url() without opening slash is not resolved or bundled
4 participants