Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make client type work with moduleResolution=node16 #10375

Merged
merged 1 commit into from Oct 9, 2022

Conversation

sapphi-red
Copy link
Member

Description

This PR fixes https://github.com/vitejs/vite-ecosystem-ci/actions/runs/3202468586/jobs/5231481088#step:7:396.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red
Copy link
Member Author

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Oct 7, 2022

📝 Ran ecosystem CI: Open

suite result
astro ✅ success
histoire ✅ success
iles ✅ success
ladle ✅ success
laravel ✅ success
marko ✅ success
nuxt-framework ✅ success
rakkas ✅ success
svelte ❌ failure
vite-plugin-ssr ✅ success
vite-setup-catalogue ✅ success
vitepress ✅ success
vitest ✅ success
windicss ✅ success

@sapphi-red
Copy link
Member Author

@dominikg
Copy link
Contributor

dominikg commented Oct 7, 2022

@dominikg Maybe svelte is failing because of https://github.com/sveltejs/vite-plugin-svelte/pull/457/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fR93-R94?

yes indeed. Thanks for pointing that out. fixed in latest vite-ecosystem-ci. no need to rerun imho

@bluwy bluwy merged commit 8c4df1f into vitejs:main Oct 9, 2022
@sapphi-red sapphi-red deleted the fix/client-type-nodenext branch October 9, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants