Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): handle parallel hookNodeResolve #10401

Merged
merged 1 commit into from Oct 10, 2022
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Oct 10, 2022

Description

hookNodeResolve is called in an async nodeImport which could run in parallel on multiple calls of ssrLoadModule. This PR tracks the hook and unhook accordingly when all parallel calls are finished.

Additional context

Fixes withastro/astro#4533

This was discussed before with @aleclarson at https://discord.com/channels/804011606160703521/930868117234647092/930868121118584913

No tests added since there wasn't a test before, but I feel like we should remove this hack in Vite 4, especially that we're going forward with ESM output.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added p3-minor-bug An edge case that only affects very specific usage (priority) feat: ssr labels Oct 10, 2022
@patak-dev
Copy link
Member

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Oct 10, 2022

📝 Ran ecosystem CI: Open

suite result
astro ✅ success
histoire ✅ success
iles ✅ success
ladle ✅ success
laravel ✅ success
marko ✅ success
nuxt-framework ✅ success
rakkas ✅ success
svelte ⏹️ cancelled
vite-plugin-ssr ✅ success
vite-setup-catalogue ✅ success
vitepress ✅ success
vitest ✅ success
windicss ✅ success

@patak-dev patak-dev merged commit 1a961d9 into main Oct 10, 2022
@patak-dev patak-dev deleted the ssr-hook-parallel-safe branch October 10, 2022 13:56
@bluwy bluwy mentioned this pull request Oct 12, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: ssr p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Call stack errors when Astro component props are changed repeatedly in MDX files
2 participants