Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add missing binding in asset import example #10414

Merged
merged 1 commit into from Oct 11, 2022
Merged

docs: add missing binding in asset import example #10414

merged 1 commit into from Oct 11, 2022

Conversation

MoustaphaDev
Copy link
Contributor

Description

Binds the _imports_0 value to the src attribute by prefixing a :. Currently, the src attribute is equal to the "_imports_0" string

Additional context

No

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@MoustaphaDev MoustaphaDev changed the title docs: missing binding in asset import example docs: add missing binding in asset import example Oct 10, 2022
@sapphi-red sapphi-red added documentation Improvements or additions to documentation plugin: vue labels Oct 11, 2022
@sapphi-red sapphi-red merged commit d7ac96d into vitejs:main Oct 11, 2022
@MoustaphaDev MoustaphaDev deleted the patch-1 branch October 11, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapphi-red sapphi-red sapphi-red approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MoustaphaDev @sapphi-red