Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(preview): support outDir option #10418

Merged
merged 2 commits into from Oct 26, 2022
Merged

feat(preview): support outDir option #10418

merged 2 commits into from Oct 26, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Oct 11, 2022

Description

Support vite preview --outDir other-dist to preview the build output for vite build --outDir other-dist.

Additional context

Raised on discord

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p2-nice-to-have Not breaking anything but nice to have (priority) label Oct 11, 2022
@sapphi-red
Copy link
Member

It seems running pnpm preview --outDir dist in playground/assets doesn't work.

@bluwy
Copy link
Member Author

bluwy commented Oct 20, 2022

@sapphi-red I think that's because the asset playground sets outDir: 'dist/foo' by default.

@sapphi-red
Copy link
Member

Ah, my bad. 🤦‍♂️

@patak-dev patak-dev merged commit 15b90b3 into main Oct 26, 2022
@patak-dev patak-dev deleted the preview-outdir branch October 26, 2022 09:32
@loganpowell
Copy link

Thank you for this! Perfect timing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@ydcjeff ydcjeff ydcjeff approved these changes

@sapphi-red sapphi-red sapphi-red approved these changes

Assignees
No one assigned
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bluwy @sapphi-red @loganpowell @patak-dev @ydcjeff