feat: include line and column in error format #10529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patak-dev
previously approved these changes
Oct 19, 2022
patak-dev
added
the
p2-nice-to-have
benmccann
previously approved these changes
Oct 19, 2022
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
manucorporat
dismissed stale reviews from benmccann and patak-dev
via
78d0cec
patak-dev
approved these changes
Oct 20, 2022
|
Great change 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When nice printing a error/warning in vite, the file does not include the line:column, this is unfortunate since vscode can follow that kind of links and the information most of the time is well known!
Additional context
Here's a small video explaining the PR:
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).