Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): resolve with isRequire true #10569

Merged
merged 1 commit into from Oct 21, 2022
Merged

fix(ssr): resolve with isRequire true #10569

merged 1 commit into from Oct 21, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Oct 21, 2022

Description

As discussed in discord (here and here). Revert the specific change from #10371.

Additional context

cc @benmccann


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@bluwy bluwy added the p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority) label Oct 21, 2022
@bluwy
Copy link
Member Author

bluwy commented Oct 21, 2022

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Oct 21, 2022

📝 Ran ecosystem CI: Open

suite result
astro ✅ success
histoire ❌ failure
iles ✅ success
ladle ✅ success
laravel ✅ success
marko ❌ failure
nuxt-framework ✅ success
rakkas ✅ success
svelte ❌ failure
vite-plugin-ssr ✅ success
vite-setup-catalogue ✅ success
vitepress ✅ success
vitest ✅ success
windicss ✅ success

@bluwy
Copy link
Member Author

bluwy commented Oct 21, 2022

Hmm looks like this fixed vite-plugin-ssr, but Svelte (specifically SvelteKit) is still failing. Marko and Histoire is currently also failing in main.

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The svelte fail is unrelated to this change, no? I think we should merge this one and attempt to change it in Vite 4 if it is breaking vite-plugin-ssr

@bluwy
Copy link
Member Author

bluwy commented Oct 21, 2022

Yeah I don't think the Svelte fail is caused by this given it failed in both cases. So something else likely caused the failure. Merging this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants