Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): strip BOM (fixes #10043) #10577

Merged
merged 1 commit into from Oct 21, 2022
Merged

Conversation

sapphi-red
Copy link
Member

Description

fixes #10043

Note that this isn't needed when postcss is enabled. postcss seems to remove BOM.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p2-edge-case Bug, but has workaround or limited in scope (priority) label Oct 21, 2022
@patak-dev patak-dev merged commit e0463bd into vitejs:main Oct 21, 2022
@sapphi-red sapphi-red deleted the fix/css-strip-bom branch October 21, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-edge-case Bug, but has workaround or limited in scope (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS with encoding UTF-8 with BOM generates \feff
2 participants