Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Dev SSR dep optimization + respect optimizeDeps.include #11123

Merged
merged 2 commits into from Nov 29, 2022
Merged

fix: Dev SSR dep optimization + respect optimizeDeps.include #11123

merged 2 commits into from Nov 29, 2022

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Nov 29, 2022 •
edited

Description

Splitted from https://github.com/vitejs/vite/pull/11057/files#r1031509805.

Additional context

I don't understand much about this so please update the PR title and description if needed.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added p3-minor-bug An edge case that only affects very specific usage (priority) feat: ssr feat: deps optimizer Esbuild Dependencies Optimization labels Nov 29, 2022
@patak-dev @sapphi-red
fix: optimize explicit deps in SSR dev
2acc682 
Co-authored-by: 翠 / green <green@sapphi.red>
@patak-dev patak-dev changed the title fix: respect optimizeDeps.include for dep optimizer fix: Dev SSR dep optimization + respect optimizeDeps.include Nov 29, 2022
@patak-dev patak-dev merged commit 515caa5 into vitejs:main Nov 29, 2022
@sapphi-red sapphi-red deleted the fix/ssr-dep-optimizer branch November 30, 2022 02:49
bluwy pushed a commit that referenced this pull request Dec 5, 2022
@sapphi-red @bluwy
fix: Dev SSR dep optimization + respect optimizeDeps.include (#11123)
3cad70f
@bluwy bluwy mentioned this pull request Dec 5, 2022
Merged
patak-dev pushed a commit that referenced this pull request Dec 5, 2022
@bluwy @gtm-nayan
@julienv3 @sapphi-red
chore: cherry pick more v4 bug fixes to v3 (#11189)
eba9b42 
* fix: glob import parsing (#10949) (#11056)

closes #10949
closes #11051

* fix: import.meta.env and process.env undefined variable replacement (fix #8663) (#10958)

Co-authored-by: bluwy <bjornlu.dev@gmail.com>
fix #8663

* fix(esbuild): handle inline sourcemap option (#11120)

* fix(importGlob): preserve line count for sourcemap (#11122)

* fix: Dev SSR dep optimization + respect optimizeDeps.include (#11123)

* fix: reset global regex before match (#11132)

* chore: fix test

Co-authored-by: gtmnayan <50981692+gtm-nayan@users.noreply.github.com>
Co-authored-by: julienv3 <julienv3@gmail.com>
Co-authored-by: 翠 / green <green@sapphi.red>
@WesSouza WesSouza mentioned this pull request Dec 17, 2022
Closed
1 task
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
@sapphi-red @futurGH
fix: Dev SSR dep optimization + respect optimizeDeps.include (vitejs#…
de0d7af 
…11123)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
feat: deps optimizer Esbuild Dependencies Optimization feat: ssr p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sapphi-red @patak-dev