Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve the error message of expand #11141

Merged
merged 3 commits into from Dec 6, 2022
Merged

feat: improve the error message of expand #11141

merged 3 commits into from Dec 6, 2022

Conversation

Dunqing
Copy link
Contributor

@Dunqing Dunqing commented Dec 1, 2022 •
edited

Description

related pr: #10826

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

benmccann
benmccann reviewed Dec 2, 2022
View reviewed changes
Copy link
Collaborator

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

packages/vite/src/node/env.ts Show resolved Hide resolved
@sapphi-red sapphi-red added this to the 4.0 milestone Dec 2, 2022
@sapphi-red sapphi-red added the p2-nice-to-have Not breaking anything but nice to have (priority) label Dec 2, 2022
@Dunqing @benmccann
Update packages/vite/src/node/env.ts
21d91ee 
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
benmccann
benmccann previously approved these changes Dec 2, 2022
View reviewed changes
ydcjeff
ydcjeff previously approved these changes Dec 3, 2022
View reviewed changes
@sapphi-red sapphi-red dismissed stale reviews from ydcjeff and benmccann via 73f4ba4 December 6, 2022 06:14
sapphi-red
sapphi-red approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@patak-dev patak-dev merged commit 825c793 into vitejs:main Dec 6, 2022
@Dunqing Dunqing mentioned this pull request Dec 6, 2022
Closed
7 tasks
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
@Dunqing @benmccann
@sapphi-red @futurGH
feat: improve the error message of expand (vitejs#11141)
6702f4f 
* feat: improve the error message of `expand`

* Update packages/vite/src/node/env.ts

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: sapphi-red <green@sapphi.red>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapphi-red sapphi-red sapphi-red approved these changes

@benmccann benmccann benmccann left review comments

@ydcjeff ydcjeff ydcjeff left review comments

Assignees
No one assigned
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Dunqing @benmccann @ydcjeff @sapphi-red @patak-dev