Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add type for function localsConvention value #11152

Merged
merged 1 commit into from Dec 3, 2022
Merged

fix: add type for function localsConvention value #11152

merged 1 commit into from Dec 3, 2022

Conversation

andrewiggins
Copy link
Contributor

Description

PostCSS Modules supports a function as a value to localsConvention. This PR adds typing for that function. See the postcss modules documentation here: https://github.com/madyankin/postcss-modules#localsconvention

Additional context

Nope

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red changed the title fix: Add type for function localsConvention value fix: add type for function localsConvention value Dec 3, 2022
@sapphi-red sapphi-red added feat: css p2-edge-case Bug, but has workaround or limited in scope (priority) labels Dec 3, 2022
@patak-dev patak-dev merged commit c9274b4 into vitejs:main Dec 3, 2022
@andrewiggins andrewiggins deleted the localsconvention-type branch December 3, 2022 18:10
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
@andrewiggins @futurGH
fix: add type for function localsConvention value (vitejs#11152)
00d6d4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@sapphi-red sapphi-red sapphi-red approved these changes

Assignees
No one assigned
Labels
feat: css p2-edge-case Bug, but has workaround or limited in scope (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andrewiggins @patak-dev @sapphi-red