Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't print urls on restart with default port #11230

Merged
merged 1 commit into from Dec 7, 2022
Merged

fix: don't print urls on restart with default port #11230

merged 1 commit into from Dec 7, 2022

Conversation

ArnaudBarre
Copy link
Member

When using the default port, config.server.port is undefined after createServer, but 5173 once listening triggers

Which causes undefined !== 5173 on the fixed line

@ArnaudBarre ArnaudBarre self-assigned this Dec 7, 2022
@patak-dev patak-dev merged commit 5aaecb6 into main Dec 7, 2022
@patak-dev patak-dev deleted the fix-url-log-restart branch December 7, 2022 07:43
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
@ArnaudBarre @futurGH
fix: don't print urls on restart with default port (vitejs#11230)
e701a64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

@patak-dev patak-dev Awaiting requested review from patak-dev

Assignees

@ArnaudBarre ArnaudBarre

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ArnaudBarre @bluwy @patak-dev