Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: less promises for scanning and await with allSettled #11245

Merged
merged 2 commits into from Dec 7, 2022

Conversation

dominikg
Copy link
Contributor

@dominikg dominikg commented Dec 7, 2022

alternative to #11243

doesn't add cancel() function to as that may have performance implications and the way the function has to be passed around isn't nice.

Description

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@dominikg dominikg changed the title fix: promises with allSettled fix: less promises for scanning and await with allSettled Dec 7, 2022
@dominikg dominikg mentioned this pull request Dec 7, 2022
9 tasks
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should go with this one for v4. Let's check the canceling with more time, and actually, see how much we win perf wise for the extra complexity.

@patak-dev
Copy link
Member

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Dec 7, 2022

📝 Ran ecosystem CI: Open

suite result
astro ✅ success
histoire ✅ success
iles ✅ success
ladle ✅ success
laravel ✅ success
marko ✅ success
nuxt-framework ❌ failure
rakkas ⏹️ cancelled
sveltekit ❌ failure
vite-plugin-ssr ❌ failure
vite-plugin-react ✅ success
vite-plugin-react-swc ✅ success
vite-plugin-svelte ✅ success
vite-plugin-vue ✅ success
vite-setup-catalogue ✅ success
vitepress ✅ success
vitest ❌ failure
windicss ✅ success

@patak-dev
Copy link
Member

/ecosystem-ci run sveltekit

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Dec 7, 2022

📝 Ran ecosystem CI: Open

suite result
sveltekit ✅ success

@patak-dev patak-dev changed the title fix: less promises for scanning and await with allSettled fix: less promises for scanning and await with allSettled Dec 7, 2022
@patak-dev patak-dev merged commit 45b170e into vitejs:main Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants