Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip shortcuts on non-tty stdin #11263

Merged
merged 1 commit into from Dec 8, 2022
Merged

fix: skip shortcuts on non-tty stdin #11263

merged 1 commit into from Dec 8, 2022

Conversation

ArnaudBarre
Copy link
Member

Fixes #11262

I've also added a CI check like we do in another places.

@patak-dev
Copy link
Member

Thanks for the quick fix!

@patak-dev patak-dev merged commit 9602686 into main Dec 8, 2022
@patak-dev patak-dev deleted the fix-shortcuts-tty branch December 8, 2022 14:37
@sapphi-red
Copy link
Member

/ecosystem-ci run vite-setup-catalogue

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Dec 8, 2022

📝 Ran ecosystem CI: Open

suite result
vite-setup-catalogue ❌ failure

@patak-dev
Copy link
Member

Uh, sorry if I merged the PR too fast 🤔

@sapphi-red
Copy link
Member

The error happened because the branch was deleted. Nvm. I'll run against the main branch 👍

Uh, sorry if I merged the PR too fast 🤔

I just wanted to confirm it. No problem 😃

@sapphi-red
Copy link
Member

It worked 💯
https://github.com/vitejs/vite-ecosystem-ci/actions/runs/3649345447/jobs/6163894052

futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vite doesn't work without tty
3 participants