fix(env): test NODE_ENV override before expand #11309
Merged
+14
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #11302
Repro https://stackblitz.com/edit/vitejs-vite-ksgf5q?file=package.json&terminal=build (incorrect build warning)
If
process.env.NODE_ENV
is already set e.g.production
, and there's aNODE_ENV=development
in the.env
file.dotenv-expand
would override asNODE_ENV=production
, making theNODE_ENV=development
check fail.This PR handles
NODE_ENV
before expand.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).