Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show server url by pressing u #11319

Merged
merged 2 commits into from Dec 12, 2022

Conversation

sapphi-red
Copy link
Member

Description

#11228 implemented keyboard shortcuts. A shortcut to open the local server URL by the browser was implemented in that PR and could be considered as a solution of #10527. But I think there's cases when I want to open other URLs or in a non-default browser.

This PR implements a shortcut to show the server URLs. This way we can avoid the terminal to be narrow. The disadvantage of this approach is that additional two steps ("focusing the terminal" and "pressing u key") are required compared to #10527's suggested solution.

closes #10527
alternative to close #10592
alternative to close #10594

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p2-nice-to-have Not breaking anything but nice to have (priority) label Dec 11, 2022
@patak-dev
Copy link
Member

I think this is a good idea 👍🏼
About #10592, it would be interesting to provide more fine grained log levels or filtering. But I agree that this PR is a better alternative.

Would you add a line break when pressing u so the printed URLs are cleaner?

image

@patak-dev patak-dev merged commit 8c0bb7b into vitejs:main Dec 12, 2022
@sapphi-red sapphi-red deleted the feat/show-url-with-u branch December 12, 2022 06:40
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Always provide access address Population
2 participants