Missing statement when building #11330

ota-meshi · 2022-12-12T11:10:33Z

Describe the bug

When I bundle and build postcss, the required statement is missing.
But in dev mode the problem does not occur.

It also happens even when minify is turned off, so I didn't know the cause. I suspect rollup is the cause of the problem, but didn't know how to check. Please let me know if you know what I should try.

Reproduction

https://github.com/ota-meshi/vite-issue-2022-12

Steps to reproduce

Run npm install
Run npm run build-and-open (This will vite build and run npx http-server dist -o.)
When you push a button in an opened browser it causes an infinite loop.

Note that dev mode does not have this problem.

The actual problematic source code is below.

https://github.com/postcss/postcss/blob/1d4c509c114a0dd8270cb5241c5eee7d01f91674/lib/tokenize.js#L235-L241

Original:

          RE_WORD_END.lastIndex = pos + 1
          RE_WORD_END.test(css)
          if (RE_WORD_END.lastIndex === 0) {
            next = css.length - 1
          } else {
            next = RE_WORD_END.lastIndex - 2
          }

Output:

          RE_WORD_END.lastIndex = pos + 1;
          if (RE_WORD_END.lastIndex === 0) {
            next = css.length - 1;
          } else {
            next = RE_WORD_END.lastIndex - 2;
          }

System Info

System:
    OS: macOS 12.4
    CPU: (4) x64 Intel(R) Core(TM) i5-6360U CPU @ 2.00GHz
    Memory: 27.96 MB / 8.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 18.12.0 - /usr/local/bin/node
    Yarn: 1.22.11 - /usr/local/bin/yarn
    npm: 8.19.2 - /usr/local/bin/npm
  Browsers:
    Chrome: 108.0.5359.98
    Chrome Canary: 110.0.5468.0
    Firefox: 79.0
    Safari: 15.5
  npmPackages:
    vite: ^4.0.0 => 4.0.0

Used Package Manager

npm

Logs

Click to expand!

  vite:config bundled config file loaded in 261.93ms +0ms
  vite:esbuild init tsconfck (root: /Users/yosuke/git/vite-issue-2022-12) +0ms
  vite:esbuild init tsconfck (root: /Users/yosuke/git/vite-issue-2022-12) +18ms
  vite:esbuild init tsconfck (root: /Users/yosuke/git/vite-issue-2022-12) +2ms
  vite:esbuild init tsconfck (root: /Users/yosuke/git/vite-issue-2022-12) +2ms
  vite:esbuild init tsconfck end +8ms
  vite:esbuild init tsconfck end +2ms
  vite:esbuild init tsconfck end +1ms
  vite:esbuild init tsconfck end +2ms
  vite:config using resolved config: {
  vite:config   build: {
  vite:config     target: [ 'es2020', 'edge88', 'firefox78', 'chrome87', 'safari14' ],
  vite:config     cssTarget: [ 'es2020', 'edge88', 'firefox78', 'chrome87', 'safari14' ],
  vite:config     outDir: 'dist',
  vite:config     assetsDir: 'assets',
  vite:config     assetsInlineLimit: 4096,
  vite:config     cssCodeSplit: true,
  vite:config     sourcemap: false,
  vite:config     rollupOptions: {},
  vite:config     minify: false,
  vite:config     terserOptions: {},
  vite:config     write: true,
  vite:config     emptyOutDir: null,
  vite:config     copyPublicDir: true,
  vite:config     manifest: false,
  vite:config     lib: false,
  vite:config     ssr: false,
  vite:config     ssrManifest: false,
  vite:config     reportCompressedSize: true,
  vite:config     chunkSizeWarningLimit: 500,
  vite:config     watch: null,
  vite:config     commonjsOptions: { include: [Array], extensions: [Array] },
  vite:config     dynamicImportVarsOptions: { warnOnError: true, exclude: [Array] },
  vite:config     modulePreload: { polyfill: true }
  vite:config   },
  vite:config   optimizeDeps: {
  vite:config     disabled: 'build',
  vite:config     force: undefined,
  vite:config     esbuildOptions: { preserveSymlinks: false }
  vite:config   },
  vite:config   configFile: '/Users/yosuke/git/vite-issue-2022-12/vite.config.mts',
  vite:config   configFileDependencies: [ '/Users/yosuke/git/vite-issue-2022-12/vite.config.mts' ],
  vite:config   inlineConfig: {
  vite:config     root: undefined,
  vite:config     base: undefined,
  vite:config     mode: undefined,
  vite:config     configFile: undefined,
  vite:config     logLevel: undefined,
  vite:config     clearScreen: undefined,
  vite:config     optimizeDeps: { force: undefined },
  vite:config     build: {}
  vite:config   },
  vite:config   root: '/Users/yosuke/git/vite-issue-2022-12',
  vite:config   base: '/',
  vite:config   rawBase: '/',
  vite:config   resolve: {
  vite:config     mainFields: [ 'module', 'jsnext:main', 'jsnext' ],
  vite:config     browserField: true,
  vite:config     conditions: [],
  vite:config     extensions: [
  vite:config       '.mjs',  '.js',
  vite:config       '.mts',  '.ts',
  vite:config       '.jsx',  '.tsx',
  vite:config       '.json'
  vite:config     ],
  vite:config     dedupe: [],
  vite:config     preserveSymlinks: false,
  vite:config     alias: [ [Object], [Object] ]
  vite:config   },
  vite:config   publicDir: '/Users/yosuke/git/vite-issue-2022-12/public',
  vite:config   cacheDir: '/Users/yosuke/git/vite-issue-2022-12/node_modules/.vite',
  vite:config   command: 'build',
  vite:config   mode: 'production',
  vite:config   ssr: {
  vite:config     format: 'esm',
  vite:config     target: 'node',
  vite:config     optimizeDeps: { disabled: true, esbuildOptions: [Object] }
  vite:config   },
  vite:config   isWorker: false,
  vite:config   mainConfig: null,
  vite:config   isProduction: true,
  vite:config   plugins: [
  vite:config     'vite:build-metadata',
  vite:config     'vite:pre-alias',
  vite:config     'alias',
  vite:config     'vite:modulepreload-polyfill',
  vite:config     'vite:resolve',
  vite:config     'vite:html-inline-proxy',
  vite:config     'vite:css',
  vite:config     'vite:esbuild',
  vite:config     'vite:json',
  vite:config     'vite:wasm-helper',
  vite:config     'vite:worker',
  vite:config     'vite:asset',
  vite:config     'vite:wasm-fallback',
  vite:config     'vite:define',
  vite:config     'vite:css-post',
  vite:config     'vite:build-html',
  vite:config     'vite:worker-import-meta-url',
  vite:config     'vite:asset-import-meta-url',
  vite:config     'vite:force-systemjs-wrap-complete',
  vite:config     'vite:watch-package-data',
  vite:config     'commonjs',
  vite:config     'vite:data-uri',
  vite:config     'vite:dynamic-import-vars',
  vite:config     'vite:import-glob',
  vite:config     'vite:build-import-analysis',
  vite:config     'vite:esbuild-transpile',
  vite:config     'vite:reporter',
  vite:config     'vite:load-fallback'
  vite:config   ],
  vite:config   server: {
  vite:config     preTransformRequests: true,
  vite:config     middlewareMode: false,
  vite:config     fs: { strict: true, allow: [Array], deny: [Array] }
  vite:config   },
  vite:config   preview: {
  vite:config     port: undefined,
  vite:config     strictPort: undefined,
  vite:config     host: undefined,
  vite:config     https: undefined,
  vite:config     open: undefined,
  vite:config     proxy: undefined,
  vite:config     cors: undefined,
  vite:config     headers: undefined
  vite:config   },
  vite:config   env: { BASE_URL: '/', MODE: 'production', DEV: false, PROD: true },
  vite:config   assetsInclude: [Function: assetsInclude],
  vite:config   logger: {
  vite:config     hasWarned: false,
  vite:config     info: [Function: info],
  vite:config     warn: [Function: warn],
  vite:config     warnOnce: [Function: warnOnce],
  vite:config     error: [Function: error],
  vite:config     clearScreen: [Function: clearScreen],
  vite:config     hasErrorLogged: [Function: hasErrorLogged]
  vite:config   },
  vite:config   packageCache: Map(0) { set: [Function (anonymous)] },
  vite:config   createResolver: [Function: createResolver],
  vite:config   worker: {
  vite:config     format: 'iife',
  vite:config     plugins: [
  vite:config       'vite:build-metadata',
  vite:config       'vite:pre-alias',
  vite:config       'alias',
  vite:config       'vite:modulepreload-polyfill',
  vite:config       'vite:resolve',
  vite:config       'vite:html-inline-proxy',
  vite:config       'vite:css',
  vite:config       'vite:esbuild',
  vite:config       'vite:json',
  vite:config       'vite:wasm-helper',
  vite:config       'vite:worker',
  vite:config       'vite:asset',
  vite:config       'vite:wasm-fallback',
  vite:config       'vite:define',
  vite:config       'vite:css-post',
  vite:config       'vite:build-html',
  vite:config       'vite:worker-import-meta-url',
  vite:config       'vite:asset-import-meta-url',
  vite:config       'vite:force-systemjs-wrap-complete',
  vite:config       'vite:watch-package-data',
  vite:config       'commonjs',
  vite:config       'vite:data-uri',
  vite:config       'vite:dynamic-import-vars',
  vite:config       'vite:import-glob',
  vite:config       'vite:build-import-analysis',
  vite:config       'vite:esbuild-transpile',
  vite:config       'vite:load-fallback'
  vite:config     ],
  vite:config     rollupOptions: {},
  vite:config     getSortedPlugins: [Function: getSortedPlugins],
  vite:config     getSortedPluginHooks: [Function: getSortedPluginHooks]
  vite:config   },
  vite:config   appType: 'spa',
  vite:config   experimental: { importGlobRestoreExtension: false, hmrPartialAccept: false },
  vite:config   getSortedPlugins: [Function: getSortedPlugins],
  vite:config   getSortedPluginHooks: [Function: getSortedPluginHooks]
  vite:config } +393ms

Validations

Follow our Code of Conduct
Read the Contributing Guidelines.
Read the docs.
Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
The provided reproduction is a minimal reproducible example of the bug.

The text was updated successfully, but these errors were encountered:

sapphi-red · 2022-12-12T12:56:05Z

I think your suspicion is correct. It reproduces with rollup.
https://stackblitz.com/edit/rollup-template-h8kok9?file=src%2Fmain.js,dist%2Fmain.js
I guess rollup/rollup#4742 will fix this.

For a workaround, using rollup 3.6.x by overrides/resolutions might work. (The regex tree-shaking seems to be introduced in 3.7.0)

ota-meshi · 2022-12-12T23:35:55Z

For a workaround, using rollup 3.6.x by overrides/resolutions might work. (The regex tree-shaking seems to be introduced in 3.7.0)

Thank you for the advice! The workaround you gave me worked fine for me!

ota-meshi · 2022-12-13T06:14:56Z

Fixed in rollup v3.7.4. Thank you!

ota-meshi added the pending triage label Dec 12, 2022

ota-meshi mentioned this issue Dec 12, 2022

playground freezes browser sveltejs/eslint-plugin-svelte#317

Closed

2 tasks

sapphi-red added bug: upstream Bug in a dependency of Vite p3-minor-bug An edge case that only affects very specific usage (priority) labels Dec 12, 2022

github-actions bot removed the pending triage label Dec 12, 2022

ota-meshi mentioned this issue Dec 12, 2022

chore: fix playground sveltejs/eslint-plugin-svelte#322

Merged

ota-meshi closed this as completed Dec 13, 2022

sapphi-red mentioned this issue Dec 13, 2022

Vite 4's bundle will run out of memory in browser #11331

Closed

7 tasks

github-actions bot locked and limited conversation to collaborators Dec 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Missing statement when building #11330

Missing statement when building #11330

ota-meshi commented Dec 12, 2022

sapphi-red commented Dec 12, 2022 •

edited

ota-meshi commented Dec 12, 2022

ota-meshi commented Dec 13, 2022

Missing statement when building #11330

Missing statement when building #11330

Comments

ota-meshi commented Dec 12, 2022

Describe the bug

Reproduction

Steps to reproduce

System Info

Used Package Manager

Logs

Validations

sapphi-red commented Dec 12, 2022 • edited

ota-meshi commented Dec 12, 2022

ota-meshi commented Dec 13, 2022

sapphi-red commented Dec 12, 2022 •

edited