Vite chokes outputting sourcemaps for modules with query parameters when there are certain kinds of plugins outputting sourcemaps from transform

[segevfiner]

Describe the bug

Using @rollup/plugin-replace with a web worker imported using ?worker causes sourcemaps to break.

Note that transform callbacks are allowed to return source maps with sources & sourcesContent not set correctly, e.g. [null], & rollup is supposed to correct the other fields, only really looking at mappings, names AFAIK.

See https://rollupjs.org/plugin-development/#source-code-transformations

Originally reported here, but pinpointed to Vite:

• Breaks when module ID includes query parameters Rich-Harris/magic-string#238
• @rollup/plugin-replace breaks when module ID includes query parameters rollup/plugins#1422

cc @YossiSaadi

Reproduction

https://github.com/segevfiner/vite-worker-sourcemaps-bug

Steps to reproduce

1. Run pnpm install & pnpm dev.
2. The sourcemaps for worker.ts and test.js are borked. Pointing to null as the source file, Vite also spews Sourcemap for "/Users/segevfiner/junk/vite-worker-sourcemaps-bug/src/worker.ts" points to missing source files.

System Info

System:
    OS: macOS 13.2
    CPU: (10) arm64 Apple M1 Pro
    Memory: 105.47 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.19.0 - ~/.nvm/versions/node/v16.19.0/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v16.19.0/bin/yarn
    npm: 9.4.0 - ~/.nvm/versions/node/v16.19.0/bin/npm
  Browsers:
    Chrome: 109.0.5414.119
    Safari: 16.3
  npmPackages:
    @vitejs/plugin-vue: ^4.0.0 => 4.0.0
    vite: ^4.0.0 => 4.1.0-beta.1

Used Package Manager

pnpm

Logs

Click to expand!

Sourcemap for "/Users/segevfiner/junk/vite-worker-sourcemaps-bug/src/worker.ts" points to missing source files
  vite:sourcemap Missing sources:
  vite:sourcemap   /Users/segevfiner/junk/vite-worker-sourcemaps-bug/src/worker.ts?type=module&worker_file +0ms

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[stereokai]

This happens to me using @rollup/plugin-replace in a regular .js file (not web worker) and without a ? in the url

[sapphi-red]

Taking a second look, this seems to be fixed by #13662.