Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): print file url in ssrTransform parse error #12060

Merged
merged 1 commit into from Feb 17, 2023

Conversation

FractalHQ
Copy link
Contributor

Description

The ssrTransform error message doesn't print the file url, making debugging difficult. This simply adds a newline with the url to the file containing the parse error.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy changed the title fix(dev) print file url in ssrTransform parse error fix(ssr): print file url in ssrTransform parse error Feb 14, 2023
@bluwy bluwy added p2-nice-to-have Not breaking anything but nice to have (priority) feat: ssr labels Feb 14, 2023
@sapphi-red sapphi-red merged commit 19f39f7 into vitejs:main Feb 17, 2023
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: ssr p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants