Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(plugin-legacy): outdated csp hash (fix #12112) #12118

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

sun0day
Copy link
Member

@sun0day sun0day commented Feb 20, 2023

Description

fix #12112

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sun0day sun0day changed the title doc(plugin-legacy): outdated csp hash (fix #12112) docs(plugin-legacy): outdated csp hash (fix #12112) Feb 20, 2023
@sun0day
Copy link
Member Author

sun0day commented Feb 20, 2023

Maybe we should just explain how to retrieve the latest csp hash in case forgetting to update the README.md.

Run `node --input-type=module -e "import {cspHashes} from '@vitejs/plugin-legacy'; console.log(cspHashes.map(h => 'sha256-'+h))"` to retrieve the value.

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's probably fine for now to update this manually as they don't change often 👍

@bluwy bluwy merged commit 5f7f5dc into vitejs:main Feb 20, 2023
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@vitejs/plugin-legacy CSP hashes outdated
2 participants