Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(importAnalysis): cache injected env string #12154

Merged
merged 2 commits into from Feb 26, 2023

Conversation

sun0day
Copy link
Member

@sun0day sun0day commented Feb 22, 2023

Description

Dedupe the env string constructing logic in importAnalysis

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sun0day
Copy link
Member Author

sun0day commented Feb 22, 2023

Is !!config.ssr equal options.ssr?

bluwy
bluwy previously approved these changes Feb 22, 2023
@bluwy
Copy link
Member

bluwy commented Feb 22, 2023

Is !!config.ssr equal options.ssr?

No, the config.ssr config could be set, but the same whole Vite config could be used to process client-side files too, so you'd need to rely on options.ssr instead.

@bluwy
Copy link
Member

bluwy commented Feb 25, 2023

@sun0day after a bit of thought, I figured it's better to cache it lazily since there's a good chance Vite apps don't use import.meta.env at all. Let me know what you think of the new changes!

@bluwy bluwy changed the title chore(importAnalysis): cache injected env string refactor(importAnalysis): cache injected env string Feb 25, 2023
@bluwy bluwy added the p2-nice-to-have Not breaking anything but nice to have (priority) label Feb 25, 2023
@sun0day
Copy link
Member Author

sun0day commented Feb 25, 2023

@sun0day after a bit of thought, I figured it's better to cache it lazily since there's a good chance Vite apps don't use import.meta.env at all. Let me know what you think of the new changes!

Nice catch. LGTM.

@bluwy bluwy merged commit 2aad552 into vitejs:main Feb 26, 2023
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants