Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manualchunks breaks build process and throws rollup error #12448

Closed
7 tasks done
welpie21 opened this issue Mar 16, 2023 · 1 comment
Closed
7 tasks done

Manualchunks breaks build process and throws rollup error #12448

welpie21 opened this issue Mar 16, 2023 · 1 comment
Labels
bug: upstream Bug in a dependency of Vite p3-minor-bug An edge case that only affects very specific usage (priority)

Comments

@welpie21
Copy link

welpie21 commented Mar 16, 2023

Describe the bug

Since vite 4.0 i've noticed that manualchunks has been moved to an other part somewhere in the configuration object. All fine moved it over how the documentation provided it.

Next time I build the project it resulted in throwing an rollup error which was kind of odd. There is a temporary work-around but I would like to use the full potential of rollup 3 instead 2.

The error that it throws you can see the image that i provided.
Schermafbeelding 2023-03-16 185746

additional note:
I get the same exact / identical error in an other project.

Reproduction

https://github.com/welpie21/vite-manualchunks-issue

Steps to reproduce

reproduce

  • pnpm install
  • pnpm build

temporary workaround

Add the following to your package.json:

	"resolutions": {
		"rollup": "2.74.1"
	},

try again:

  • pnpm install
  • pnpm build
  • works

System Info

System:
    OS: Windows 10 10.0.22621
    CPU: (16) x64 AMD Ryzen 7 5800X 8-Core Processor
    Memory: 35.61 GB / 47.92 GB
  Binaries:
    Node: 18.14.2 - C:\Program Files\nodejs\node.EXE
    npm: 9.5.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.22621.1413.0), Chromium (111.0.1661.43)

Used Package Manager

pnpm

Logs

Click to expand!
  vite:config bundled config file loaded in 41.50ms +0ms
  vite:esbuild init tsconfck (root: C:/Users/beaud/Documents/GitHub/vite-manualchunks-issue) +0ms
  vite:esbuild init tsconfck (root: C:/Users/beaud/Documents/GitHub/vite-manualchunks-issue) +0ms
  vite:esbuild init tsconfck (root: C:/Users/beaud/Documents/GitHub/vite-manualchunks-issue) +1ms
  vite:esbuild init tsconfck (root: C:/Users/beaud/Documents/GitHub/vite-manualchunks-issue) +1ms
  vite:esbuild init tsconfck end +1ms
  vite:esbuild init tsconfck end +0ms
  vite:esbuild init tsconfck end +1ms
  vite:esbuild init tsconfck end +0ms
  vite:config using resolved config: {
  vite:config   plugins: [
  vite:config     'vite:build-metadata',
  vite:config     'vite:pre-alias',
  vite:config     'alias',
  vite:config     'vite:modulepreload-polyfill',
  vite:config     'vite:resolve',
  vite:config     'vite:html-inline-proxy',
  vite:config     'vite:css',
  vite:config     'vite:esbuild',
  vite:config     'vite:json',
  vite:config     'vite:wasm-helper',
  vite:config     'vite:worker',
  vite:config     'vite:asset',
  vite:config     'vite:react-swc',
  vite:config     'vite:split-vendor-chunk',
  vite:config     'vite:wasm-fallback',
  vite:config     'vite:define',
  vite:config     'vite:css-post',
  vite:config     'vite:build-html',
  vite:config     'vite:worker-import-meta-url',
  vite:config     'vite:asset-import-meta-url',
  vite:config     'vite:force-systemjs-wrap-complete',
  vite:config     'vite:watch-package-data',
  vite:config     'commonjs',
  vite:config     'vite:data-uri',
  vite:config     'vite:dynamic-import-vars',
  vite:config     'vite:import-glob',
  vite:config     'vite:build-import-analysis',
  vite:config     'vite:esbuild-transpile',
  vite:config     'vite:terser',
  vite:config     'vite:reporter',
  vite:config     'vite:load-fallback'
  vite:config   ],
  vite:config   mode: 'production',
  vite:config   build: {
  vite:config     target: [ 'es2020', 'edge88', 'firefox78', 'chrome87', 'safari14' ],
  vite:config     cssTarget: [ 'es2020', 'edge88', 'firefox78', 'chrome87', 'safari14' ],
  vite:config     outDir: 'dist',
  vite:config     assetsDir: 'assets',
  vite:config     assetsInlineLimit: 4096,
  vite:config     cssCodeSplit: true,
  vite:config     sourcemap: false,
  vite:config     rollupOptions: { output: [Object] },
  vite:config     minify: 'esbuild',
  vite:config     terserOptions: {},
  vite:config     write: true,
  vite:config     emptyOutDir: null,
  vite:config     copyPublicDir: true,
  vite:config     manifest: false,
  vite:config     lib: false,
  vite:config     ssr: false,
  vite:config     ssrManifest: false,
  vite:config     ssrEmitAssets: false,
  vite:config     reportCompressedSize: true,
  vite:config     chunkSizeWarningLimit: 500,
  vite:config     watch: null,
  vite:config     commonjsOptions: { include: [Array], extensions: [Array] },
  vite:config     dynamicImportVarsOptions: { warnOnError: true, exclude: [Array] },
  vite:config     modulePreload: { polyfill: true },
  vite:config     cssMinify: true
  vite:config   },
  vite:config   optimizeDeps: {
  vite:config     disabled: 'build',
  vite:config     force: undefined,
  vite:config     esbuildOptions: { preserveSymlinks: false }
  vite:config   },
  vite:config   esbuild: {
  vite:config     jsxDev: false,
  vite:config     jsx: 'automatic',
  vite:config     jsxImportSource: 'react',
  vite:config     tsconfigRaw: { compilerOptions: [Object] }
  vite:config   },
  vite:config   configFile: 'C:/Users/beaud/Documents/GitHub/vite-manualchunks-issue/vite.config.ts',
  vite:config   configFileDependencies: [
  vite:config     'C:/Users/beaud/Documents/GitHub/vite-manualchunks-issue/vite.config.ts'
  vite:config   ],
  vite:config   inlineConfig: {
  vite:config     root: undefined,
  vite:config     base: undefined,
  vite:config     mode: undefined,
  vite:config     configFile: undefined,
  vite:config     logLevel: undefined,
  vite:config     clearScreen: undefined,
  vite:config     optimizeDeps: { force: undefined },
  vite:config     build: {}
  vite:config   },
  vite:config   root: 'C:/Users/beaud/Documents/GitHub/vite-manualchunks-issue',
  vite:config   base: '/',
  vite:config   rawBase: '/',
  vite:config   resolve: {
  vite:config     mainFields: [ 'module', 'jsnext:main', 'jsnext' ],
  vite:config     browserField: true,
  vite:config     conditions: [],
  vite:config     extensions: [
  vite:config       '.mjs',  '.js',
  vite:config       '.mts',  '.ts',
  vite:config       '.jsx',  '.tsx',
  vite:config       '.json'
  vite:config     ],
  vite:config     dedupe: [],
  vite:config     preserveSymlinks: false,
  vite:config     alias: [ [Object], [Object] ]
  vite:config   },
  vite:config   publicDir: 'C:\\Users\\beaud\\Documents\\GitHub\\vite-manualchunks-issue\\public',
  vite:config   cacheDir: 'C:/Users/beaud/Documents/GitHub/vite-manualchunks-issue/node_modules/.vite',
  vite:config   command: 'build',
  vite:config   ssr: {
  vite:config     format: 'esm',
  vite:config     target: 'node',
  vite:config     optimizeDeps: { disabled: true, esbuildOptions: [Object] }
  vite:config   },
  vite:config   isWorker: false,
  vite:config   mainConfig: null,
  vite:config   isProduction: true,
  vite:config   server: {
  vite:config     preTransformRequests: true,
  vite:config     sourcemapIgnoreList: [Function (anonymous)],
  vite:config     middlewareMode: false,
  vite:config     fs: { strict: true, allow: [Array], deny: [Array] }
  vite:config   },
  vite:config   preview: {
  vite:config     port: undefined,
  vite:config     strictPort: undefined,
  vite:config     host: undefined,
  vite:config     https: undefined,
  vite:config     open: undefined,
  vite:config     proxy: undefined,
  vite:config     cors: undefined,
  vite:config     headers: undefined
  vite:config   },
  vite:config   envDir: 'C:/Users/beaud/Documents/GitHub/vite-manualchunks-issue',
  vite:config   env: {
  vite:config     VITE_CONNECTION_DATABASE: 'showpain',
  vite:config     VITE_CONNECTION_ENDPOINT: 'http://showpain.nl',
  vite:config     VITE_CONNECTION_NAMESPACE: 'showpain',
  vite:config     BASE_URL: '/',
  vite:config     MODE: 'production',
  vite:config     DEV: false,
  vite:config     PROD: true
  vite:config   },
  vite:config   assetsInclude: [Function: assetsInclude],
  vite:config   logger: {
  vite:config     hasWarned: false,
  vite:config     info: [Function: info],
  vite:config     warn: [Function: warn],
  vite:config     warnOnce: [Function: warnOnce],
  vite:config     error: [Function: error],
  vite:config     clearScreen: [Function: clearScreen],
  vite:config     hasErrorLogged: [Function: hasErrorLogged]
  vite:config   },
  vite:config   packageCache: Map(0) { set: [Function (anonymous)] },
  vite:config   createResolver: [Function: createResolver],
  vite:config   worker: {
  vite:config     format: 'iife',
  vite:config     plugins: [
  vite:config       'vite:build-metadata',
  vite:config       'vite:pre-alias',
  vite:config       'alias',
  vite:config       'vite:modulepreload-polyfill',
  vite:config       'vite:resolve',
  vite:config       'vite:html-inline-proxy',
  vite:config       'vite:css',
  vite:config       'vite:esbuild',
  vite:config       'vite:json',
  vite:config       'vite:wasm-helper',
  vite:config       'vite:worker',
  vite:config       'vite:asset',
  vite:config       'vite:wasm-fallback',
  vite:config       'vite:define',
  vite:config       'vite:css-post',
  vite:config       'vite:build-html',
  vite:config       'vite:worker-import-meta-url',
  vite:config       'vite:asset-import-meta-url',
  vite:config       'vite:force-systemjs-wrap-complete',
  vite:config       'vite:watch-package-data',
  vite:config       'commonjs',
  vite:config       'vite:data-uri',
  vite:config       'vite:dynamic-import-vars',
  vite:config       'vite:import-glob',
  vite:config       'vite:build-import-analysis',
  vite:config       'vite:esbuild-transpile',
  vite:config       'vite:terser',
  vite:config       'vite:load-fallback'
  vite:config     ],
  vite:config     rollupOptions: {},
  vite:config     getSortedPlugins: [Function: getSortedPlugins],
  vite:config     getSortedPluginHooks: [Function: getSortedPluginHooks]
  vite:config   },
  vite:config   appType: 'spa',
  vite:config   experimental: { importGlobRestoreExtension: false, hmrPartialAccept: false },
  vite:config   getSortedPlugins: [Function: getSortedPlugins],
  vite:config   getSortedPluginHooks: [Function: getSortedPluginHooks]
  vite:config } +13ms
vite v4.2.0 building for production...
✓ 638 modules transformed.
transforming (738) node_modules\.pnpm\@babel+runtime@7.21.0\node_modules\@babel\runtime\helpers\esm\assertThisInitialized.jsCannot read properties of undefined (reading 'type')
✓ built in 3.39s
error during build:
TypeError: Cannot read properties of undefined (reading 'type')
    at FunctionExpression.deoptimizeArgumentsOnInteractionAtPath (file:///C:/Users/beaud/Documents/GitHub/vite-manualchunks-issue/node_modules/.pnpm/rollup@3.19.1/node_modules/rollup/dist/es/shared/node-entry.js:8577:25)
    at FunctionExpression.deoptimizeArgumentsOnInteractionAtPath (file:///C:/Users/beaud/Documents/GitHub/vite-manualchunks-issue/node_modules/.pnpm/rollup@3.19.1/node_modules/rollup/dist/es/shared/node-entry.js:8973:15)
    at CallExpression.applyDeoptimizations (file:///C:/Users/beaud/Documents/GitHub/vite-manualchunks-issue/node_modules/.pnpm/rollup@3.19.1/node_modules/rollup/dist/es/shared/node-entry.js:9694:21)
    at CallExpression.hasEffects (file:///C:/Users/beaud/Documents/GitHub/vite-manualchunks-issue/node_modules/.pnpm/rollup@3.19.1/node_modules/rollup/dist/es/shared/node-entry.js:9660:22)
    at ExpressionStatement.hasEffects (file:///C:/Users/beaud/Documents/GitHub/vite-manualchunks-issue/node_modules/.pnpm/rollup@3.19.1/node_modules/rollup/dist/es/shared/node-entry.js:5770:28)
    at Program.hasEffects (file:///C:/Users/beaud/Documents/GitHub/vite-manualchunks-issue/node_modules/.pnpm/rollup@3.19.1/node_modules/rollup/dist/es/shared/node-entry.js:11635:22)
    at Program.hasCachedEffects (file:///C:/Users/beaud/Documents/GitHub/vite-manualchunks-issue/node_modules/.pnpm/rollup@3.19.1/node_modules/rollup/dist/es/shared/node-entry.js:11630:44)
    at Module.hasEffects (file:///C:/Users/beaud/Documents/GitHub/vite-manualchunks-issue/node_modules/.pnpm/rollup@3.19.1/node_modules/rollup/dist/es/shared/node-entry.js:13521:75)
    at addSideEffectDependencies (file:///C:/Users/beaud/Documents/GitHub/vite-manualchunks-issue/node_modules/.pnpm/rollup@3.19.1/node_modules/rollup/dist/es/shared/node-entry.js:13861:72)
    at Module.addRelevantSideEffectDependencies (file:///C:/Users/beaud/Documents/GitHub/vite-manualchunks-issue/node_modules/.pnpm/rollup@3.19.1/node_modules/rollup/dist/es/shared/node-entry.js:13868:9)      
 ELIFECYCLE  Command failed with exit code 1.

Validations

@sapphi-red
Copy link
Member

This is a bug in rollup: rollup/rollup#4908

@sapphi-red sapphi-red closed this as not planned Won't fix, can't repro, duplicate, stale Mar 17, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug: upstream Bug in a dependency of Vite p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

No branches or pull requests

2 participants