perf(resolve): skip absolute paths in root as url checks #12476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bluwy
previously approved these changes
Mar 19, 2023
bluwy
added
p4-important
bluwy
approved these changes
Mar 19, 2023
sapphi-red
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements @bluwy's idea of a pre-cached
root/rootcheck when resolving absolute paths, allowing skipping the check as a URL for common absolute paths. See #12471 (comment)After this PR, #12471 still counts as an optimization if we merge #12450
We could add a watcher to check if
root/rootis created after the server starts but I feel it is a very uncommon edge case and we could keep it simple. Open to adding more complexity if we think that is important here.What is the purpose of this pull request?