perf(css): improve postcss config resolve #12484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluwy
added
feat: css
p4-important
|
|
bluwy
commented
Mar 19, 2023
Comment on lines
-806
to
+809
| const postcssConfig = await resolvePostcssConfig(config, getCssDialect(lang)) | ||
| const postcssConfig = await resolvePostcssConfig(config) |
There was a problem hiding this comment.
Dialect option can be removed as it was only separated because sugarss mutates the config to add the sugarss parser. Down the code I've refactored to not mutate the config so we can keep a single cache as before.
|
This is awesome 🔥 |
patak-dev
reviewed
Mar 19, 2023
ArnaudBarre
previously approved these changes
Mar 19, 2023
Co-authored-by: patak <matias.capeletto@gmail.com>
patak-dev
approved these changes
Mar 20, 2023
sapphi-red
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With many parallel CSS file requests (especially with
preTransformRequest), each CSS will try to resolve thepostcssconfig because the cache has not been filled. This is slow as we only need one CSS file to resolve it, while others can wait for that one result. Otherwise all CSS files will resolve their own postcss config at once, causing slowness.On top of that,
postcss-load-configtakes strangely long to load (2s for me), especially if you don't have a config at all. So we need to reduce calling it.This PR does the above by caching the promise of the config resolve, instead of it's result.
Additional context
Debugging the slowness in https://github.com/sveltejs/vite-plugin-svelte/tree/main/packages/playground/big
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).