Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: simplify prettyUrl #12488

Merged
merged 1 commit into from Mar 20, 2023
Merged

fix: simplify prettyUrl #12488

merged 1 commit into from Mar 20, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Mar 20, 2023

Description

When debugging locally with pnpm, I often get:

vite:transform 0.88ms npm: .pnpm +19ms

This PR expands it fully to the whole path like:

vite:transform 0.37ms ../../../node_modules/.pnpm/svelte-hmr@0.15.1_svelte@3.56.0/node_modules/svelte-hmr/runtime/svelte-hooks.js?v=d5665ff4 +12ms

since it's nicer to know which file exactly Vite is working on.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p2-nice-to-have Not breaking anything but nice to have (priority) label Mar 20, 2023
@stackblitz
Copy link

stackblitz bot commented Mar 20, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev merged commit ebe5aa5 into main Mar 20, 2023
11 checks passed
@patak-dev patak-dev deleted the simplify-pretty-url branch March 20, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants