fix: prevent error on not set location href

[mschakulat]

Description

The current implementation of the function cleanScssBugUrl checks if the 'window' and 'location' globals are defined, and then replaces the prefix of the URL with the location href. However, in some cases, the 'location.href' value can be undefined, resulting in an error.

To resolve this issue, I've updated the code to use optional chaining (?.) to ensure that the 'replace' function only runs if 'location.href' is defined. This modification ensures that the function can handle cases where 'location.href' is undefined and prevents errors from being thrown.

This change has been tested and verified to work as expected.

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines.
• Read the Pull Request Guidelines and follow the PR Title Convention.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Ideally, include relevant tests that fail without this PR but pass with it.

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[patak-dev]

I think we could replace 1546 with typeof location?.href === 'string'. If href isn't defined, then we don't need to call replace

[bluwy]

@mschakulat you haven't fixed this part yet, which I agree would be a nicer check

[mschakulat]

@bluwy Yes, that's correct. I have adjusted it.

[MichalKalita]

Unfortunately condition must be typeof location !== 'undefined'.
In my project with svelte-kit and scss doesn't work new condition, because location is not defined.

Optional chaining doesn't work on not defined variables.

[patak-dev]

Would you give more info about your environment that is triggering this bug? Interesting that we didn't get a report before.

[mschakulat]

Would you give more info about your environment that is triggering this bug? Interesting that we didn't get a report before.

Unfortunately i can't say too much about it. We use a proprietary package (https://bitmovin.com/). The code is encrypted and therefore the context is hard to see. But I see that the 'location' object is edited there: typeof location?location:{}}.