Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: should generate Hi-res sourcemap for dev #12501

Merged
merged 1 commit into from Mar 21, 2023

Conversation

fi3ework
Copy link
Member

@fi3ework fi3ework commented Mar 20, 2023

Description

When developing Vite, it's very painful to find that breakpoints sometimes can't be added on some lines randomly with VS Code. Should use hi-res sourcemap to get a better debugging experience.

Tested in https://evanw.github.io/source-map-visualization/

before:

image

after:

image

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Mar 20, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@patak-dev patak-dev merged commit 1502617 into vitejs:main Mar 21, 2023
15 checks passed
@fi3ework fi3ework deleted the high-res-dev branch March 21, 2023 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants