perf: remove regex in ImportMetaURL plugins #12502
Conversation
|
|
| @@ -52,7 +56,7 @@ export function assetImportMetaUrlPlugin(config: ResolvedConfig): Plugin { | |||
| if (!s) s = new MagicString(code) | |||
|
|
|||
| // potential dynamic template string | |||
| if (rawUrl[0] === '`' && /\$\{/.test(rawUrl)) { | |||
| if (rawUrl[0] === '`' && placeholderRE.test(rawUrl)) { | |||
There was a problem hiding this comment.
Maybe we can use rawUrl.includes('${') instead?
There was a problem hiding this comment.
I would also expect this to be faster, but if the regex is extracted it isn't clear: benchmark. I'll replace it anyways but I would love to know why it isn't always faster.
There was a problem hiding this comment.
The regex is consistently faster on chrome on M1 🤔
There was a problem hiding this comment.
It seems .includes is consistently faster on my machine even if the regex is extracted. 🤔
I'm not sure about the reason though.
There was a problem hiding this comment.
Interesting 👀
Ok, switched to includes as I also expect that to be faster.
Also did the same for the worker plugin
patak-dev
changed the title
patak-dev
changed the title
|
We can't extract these regexes, as there are |
Ah, that's a good catch. Maybe we can extract them if we replaced |
Description
One of the regex is expensive to generate
What is the purpose of this pull request?